-
Notifications
You must be signed in to change notification settings - Fork 33.8k
fixing iconlabel css #250882
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fixing iconlabel css #250882
Conversation
If the changes appear safe, you can manually trigger the pipeline by commenting |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm, reverts original change in the icon label and has more specific fix just for chat 👍🏻
@@ -1182,6 +1182,11 @@ have to be updated for changes to the rules above, or to support more deeply nes | |||
border-color: var(--vscode-focusBorder); | |||
} | |||
|
|||
.chat-attached-context-attachment .monaco-icon-label > .monaco-icon-label-container > .monaco-icon-suffix-container > .label-suffix { | |||
color: var(--vscode-peekViewTitleDescription-foreground); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is the peek view token the right thing to use here, since that might normally be on a different background color than the peek view?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i figured it might be okay since this is only in chat pills, but @kkbrooks i'm not sure if you've looked into where else it's used and if it passes the accessibility stuff?
otherwise, could just be worth making a new token like we talked about
fixing iconlabel css
Changes to label styles:
src/vs/base/browser/ui/iconLabel/iconlabel.css
: Updated the.label-suffix
and.label-description
elements to useopacity: .7
instead of the--vscode-peekViewTitleDescription-foreground
color variable, ensuring a consistent semi-transparent appearance.src/vs/workbench/contrib/chat/browser/media/chat.css
: Added a new style for.chat-attached-context-attachment .label-suffix
to explicitly set the color to--vscode-peekViewTitleDescription-foreground
, ensuring it passes accessibility in this specific context.The accessibility due date for this fix is June 16