chat: don't recreate empty file if previously deleted on workspace restoration #251018
Conversation
|
Joh is out on vacation. Assigning to Rob to take a look. |
There was a problem hiding this comment.
Thanks for the PR! You should be able to use the copilot extension in OSS by downloading the vsix and using "Install Extension from VSIX". Or, something like starting oss with --extensions-dir=~/.vscode/extensions. Does that help?
I don't have time to test it right now, I can look later.
| @@ -523,6 +523,16 @@ export class ChatEditingSession extends Disposable implements IChatEditingSessio | |||
| const entriesArr: AbstractChatEditingModifiedFileEntry[] = []; | |||
| // Restore all entries from the snapshot | |||
| for (const snapshotEntry of entries.values()) { | |||
| // During workspace restore, check if the file exists on disk before attempting to restore it | |||
| if (isWorkspaceRestore) { | |||
There was a problem hiding this comment.
I believe you could also just use the restoreToDisk flag for this, seems like the same intent
Unfortunately, I'm unable to test it out at the moment. I'll try if/when I have some time. |
This should fix microsoft/vscode-copilot-release#11990
I cannot try this (as this depends on the Copilot extensions).
@isidorn