Support unsetting signing commits #252263
Open
+2
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1866,6 +1866,8 @@ export class Repository { | |||
|
|
|||
| if (opts.signCommit) { | |||
| args.push('-S'); | |||
| } else if (opts.signCommit === false) { | |||
There was a problem hiding this comment.
The use of args.unshift('-c', 'commit.gpgSign=false'); is the right way to temporarily disable commit signing for this single git command.
There was a problem hiding this comment.
I had a look at Stackoverflow too - How to disable git gpg signing.
I do believe it should work and passing -c commit.gpgSign=false on the command line overrides any global or local Git configuration and disables gpg signing for that single git commit.
To test this:
Make a commit normally and check that it's signed. Then, make a commit with signing disabled (using the new option) and check that it's not signed. The first commit should have a valid gpg signature whilst the second one should have no signature.
joshspicer
approved these changes
Jun 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #252261