Skip to content

Adopting variable fonts #252308

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 257 commits into from
Jun 30, 2025
Merged

Adopting variable fonts #252308

merged 257 commits into from
Jun 30, 2025

Conversation

aiday-mar
Copy link
Contributor

@aiday-mar aiday-mar commented Jun 24, 2025 •
edited
Loading

This PR allows to have variable fonts in the editor. There are still some issues however which should be addressed at a later stage:

  • The line breaks are not computed correctly. To fix this, we should use the DomLineBreaksComputer code when the line has variable fonts and apply all the inline decorations exactly as is from the editor. This will be done in a separate PR.

@aiday-mar
changikng the font size and the line height directly in the code
8a71210
@aiday-mar
wip
f4e5ada
@aiday-mar
wip
8afcd7b
@aiday-mar
removing monaco editor related code
6c110ab
@aiday-mar
wip
5ee4853
@aiday-mar
wip
38dfbf6
@aiday-mar
wip
d0685e2
@aiday-mar
adding wip
f7ba276
@aiday-mar
setting doc as internal
f7d47a3
@aiday-mar
pushing to text to the bottom
cf367af
@aiday-mar
adding support for font size
e329622
@aiday-mar
placing at the end
91d4be2
@aiday-mar
fixing tests
f7837fb
@aiday-mar
adding likne height setting
25492d2
@aiday-mar
adding comments
aaaad55
@aiday-mar
adding todo
6395ef1
@aiday-mar
overriding the font size in sticky scroll
549e9ed
@aiday-mar
making sticky scroll also use the editor lines heights
95f7739
@aiday-mar
updating sticky scroll on decoration change, investigating lines
ce134e3
@aiday-mar
Merge branch 'main' into line-height
9dec371
@aiday-mar
removing changes for font size, focusing on line height changes
952f891
@aiday-mar
adding code
9f7b34c
@aiday-mar
adding css changes to position text at the bottom
c6d8a6d
@aiday-mar
adding also the chnages for demo
6ab9c03
@aiday-mar
adding code
20d1702
@aiday-mar
making content widgets correctly position themselves
54e8958
@aiday-mar
adding css changes to sticky scroll
e75e7f1
@aiday-mar
adding more methods
c7ce4b2
@aiday-mar
adding code
13e7c56
@aiday-mar
polishing
5addef1
@aiday-mar aiday-mar requested a review from alexdima June 25, 2025 10:45
@aiday-mar aiday-mar marked this pull request as ready for review June 25, 2025 10:45
@aiday-mar aiday-mar enabled auto-merge (squash) June 25, 2025 10:45
@aiday-mar aiday-mar disabled auto-merge June 25, 2025 10:45
@aiday-mar aiday-mar enabled auto-merge (squash) June 25, 2025 10:45
@aiday-mar aiday-mar changed the title adopting variable fonts Adopting variable fonts Jun 25, 2025
@vs-code-engineering vs-code-engineering bot added this to the June 2025 milestone Jun 25, 2025
alexdima
alexdima requested changes Jun 30, 2025
View reviewed changes
Copy link
Member

@alexdima alexdima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good! Just one small problem around forcing stickiness to never grow at edges when font size is configured, please undo that part and then we should be good to go.

@aiday-mar aiday-mar requested a review from alexdima June 30, 2025 11:29
@aiday-mar aiday-mar merged commit 474b70c into main Jun 30, 2025
8 checks passed
@aiday-mar aiday-mar deleted the font-size-5 branch June 30, 2025 13:15
@codeOwlAI codeOwlAI mentioned this pull request Jun 30, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexdima alexdima alexdima approved these changes

Assignees

@aiday-mar aiday-mar

Labels
None yet
Projects
None yet
Milestone
June 2025
Development

Successfully merging this pull request may close these issues.
2 participants
@aiday-mar @alexdima