Fix codicon shifting in hover widgets during async content loading #252345
+6
−0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes an issue where codicons would shift position in hover widgets when content loads asynchronously, particularly noticeable in git blame editor decoration hovers.
Problem
When hovering over git blame decorations, codicons (like
$(history)
,$(git-commit)
,$(copy)
,$(gear)
) would initially appear in one position, then shift when the hover content finished loading asynchronously. This happened because:Solution
Added CSS properties to ensure stable codicon positioning during content loading:
display: inline-block
- Maintains consistent box model behavior during layout changesline-height: 1
- Provides stable vertical spacing regardless of surrounding contentThe fix is applied to two selectors to ensure comprehensive coverage:
.monaco-hover .markdown-hover .hover-contents .codicon
- General codicons in markdown hovers.monaco-hover .markdown-hover .hover-contents:not(.code-hover-contents):not(.html-hover-contents) span.codicon
- Specific span codicons (already had margin fixes)Testing
The changes are minimal (6 lines added, 0 deleted) and focused specifically on preventing layout shifts without affecting existing functionality.
Fixes #238356.
Warning
Firewall rules blocked me from connecting to one or more addresses
I tried to connect to the following addresses, but was blocked by firewall rules:
electronjs.org
node-gyp
(dns block)If you need me to access, download, or install something from one of these locations, you can either:
💬 Share your feedback on Copilot coding agent for the chance to win a $200 gift card! Click here to start the survey.