Skip to content

fix: cleanup web worker when worker client gets disposed #253732

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

fix: cleanup web worker when worker client gets disposed #253732

wants to merge 2 commits into from

Conversation

deepak1556
Copy link
Collaborator

Fixes #253663

@deepak1556 deepak1556 added this to the June 2025 milestone Jul 2, 2025
@deepak1556 deepak1556 requested a review from bpasero July 2, 2025 19:51
@deepak1556 deepak1556 self-assigned this Jul 2, 2025
@deepak1556 deepak1556 enabled auto-merge (squash) July 2, 2025 19:57
bpasero
bpasero previously approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@bpasero bpasero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a bit strange having a class that disposes the thing that gets passed in, but the web worker cannot be created inside due to layer issues...

@deepak1556
Copy link
Collaborator Author

Thanks!

@deepak1556 deepak1556 closed this Jul 3, 2025
auto-merge was automatically disabled July 3, 2025 17:32

Pull request was closed

@deepak1556 deepak1556 reopened this Jul 3, 2025
@deepak1556 deepak1556 enabled auto-merge (squash) July 3, 2025 17:33
@deepak1556 deepak1556 closed this Jul 3, 2025
auto-merge was automatically disabled July 3, 2025 17:51

Pull request was closed

@deepak1556 deepak1556 deleted the robo/fix_worker_termination branch July 3, 2025 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bpasero bpasero bpasero approved these changes

@aeschli aeschli aeschli approved these changes

Assignees

@deepak1556 deepak1556

Labels
None yet
Projects
None yet
Milestone
June 2025
Development

Successfully merging this pull request may close these issues.

Look into why there are so many CpuProfileAnalysisWorkers
3 participants
@deepak1556 @bpasero @aeschli