Fix some missing indentationRules and indentation on ctrl+shift+enter #52209
Conversation
Use current line's indentation if language doesn't have indentation rules
|
|
|
Any progress on this? |
rebornix
added
editor-autoindent
|
I'm not sure if we want to invest more in textmate indentation rules at this moment. I'm leaning towards no but I'll leave this decision to @aiday-mar. |
There was a problem hiding this comment.
Hi thank you for making this PR and apologies for the delay in reviewing. I have looked at the PR and I think this is a promising PR. Could we do the following:
There is a merge conflict, could we resolve it?
You have added changes to the language configuration files in the same PR as you made a change to the src/vs/editor/common/controller/cursorTypeOperations.ts file. Could you separate these two into 2 PRs as these are fixing different issues
For each indentation rules you have added could you link the corresponding place you found them from? You mentioned they are taken from some Atom packages, I would like to have a look.
Thank you
Fixes #51802
Fixes #29134
Makes "Insert Line Above" command use current line's indentation when no indentationRules exist for the current language.
All indentationRules were copied/converted from the source language package or from a similar Atom package. Some language packages still don't have any indentationRules because I couldn't find any.