Skip to content

New package: Brother.BRAdmin.Professional.4 version 1.19.0000 #267059

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

New package: Brother.BRAdmin.Professional.4 version 1.19.0000 #267059

merged 2 commits into from
Jul 2, 2025

Conversation

Dragon1573
Copy link
Contributor

@Dragon1573 Dragon1573 commented Jun 19, 2025 •
edited by microsoft-github-policy-service bot
Loading

Checklist for Pull Requests

Manifests

  • Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.

Microsoft Reviewers: Open in CodeFlow

@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-267059-20250619-1

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Forbidden-URL-Error labels Jun 19, 2025
@wingetbot
Copy link
Collaborator

Url Validation Error

@Dragon1573
Apply suggestions from code review
3fb3b85 
- Comment out for avoiding "HTTP 403 Forbidden" complaint.
@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-267059-20250619-2

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. New-Package Validation-Forbidden-URL-Error labels Jun 19, 2025
@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jun 19, 2025
@stephengillie
Copy link
Collaborator

Manual Validation ended with:
image
It seems as though the package uninstalled itself during the scan step. I'm not completely sure.

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jun 20, 2025
@Dragon1573
Copy link
Contributor Author

😕 It failed to install in my Windows Sandbox instance. Can't figure out why.

PixPin_2025-06-21_16-37-25

2025-06-21 16:32:41.742 [WORK] Running task: ExecuteInstallerForType
2025-06-21 16:32:41.742 [WORK] Getting data item: 7
2025-06-21 16:32:41.856 [WORK] Running task: 0x00007FFC0CD291A0 [ln 00000001`80000000+2391a0]
2025-06-21 16:32:41.856 [WORK] Running task: 0x00007FFC0CD58870 [ln 00000001`80000000+268870]
2025-06-21 16:32:41.856 [WORK] Getting data item: 7
2025-06-21 16:32:41.856 [WORK] Getting data item: 5
2025-06-21 16:32:41.863 [CLI ] Installer args: /S /v/qn
2025-06-21 16:32:41.863 [WORK] Setting data item: 11
2025-06-21 16:32:41.864 [WORK] Running task: 0x00007FFC0CD5A7F0 [ln 00000001`80000000+26a7f0]
2025-06-21 16:32:41.864 [WORK] Getting data item: 7
2025-06-21 16:32:41.864 [WORK] Getting data item: 11
2025-06-21 16:32:41.864 [WORK] Getting data item: 9
2025-06-21 16:32:41.864 [CLI ] Starting: 'C:\Users\WDAGUtilityAccount\AppData\Local\Temp\WinGet\Brother.BRAdmin.Professional.4.1.19.0000\Setup_BRAdminPro4_1.19.0000.exe' with arguments '/S /v/qn'
2025-06-21 16:36:49.005 [WORK] Setting data item: 12
2025-06-21 16:36:49.005 [WORK] Running task: ReportInstallerResult
2025-06-21 16:36:49.005 [WORK] Getting data item: 12
2025-06-21 16:36:49.005 [WORK] Getting data item: 7
2025-06-21 16:36:49.005 [WORK] Getting data item: 7
2025-06-21 16:36:49.005 [WORK] Getting data item: 5
2025-06-21 16:36:49.005 [CLI ] ShellExecute installer failed: 1603
2025-06-21 16:36:49.005 [WORK] Checking data item: 10
2025-06-21 16:36:49.006 [CLI ] Terminating context: 0x8a150006 at C:\__w\1\s\external\pkg\src\AppInstallerCLICore\Workflows\InstallFlow.cpp:223
2025-06-21 16:36:49.006 [WORK] Running task: RegisterStartupAfterReboot

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jun 21, 2025
@ItzLevvie
Copy link
Contributor

@wingetbot run

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-267059-20250701-1

@microsoft-github-policy-service microsoft-github-policy-service bot removed Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. Validation-Completed Validation passed labels Jul 1, 2025
@wingetbot wingetbot added Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 1, 2025
@wingetbot wingetbot added the Validation-Completed Validation passed label Jul 2, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 2, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 2, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 2, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 2, 2025
@wingetbot wingetbot added Validation-Completed Validation passed and removed Validation-Completed Validation passed labels Jul 2, 2025
@ItzLevvie
Copy link
Contributor

Installs fine on AMD EPYC 9655.

image
image

[Policy] Needs-Manual-Merge

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer Needs-Attention This work item needs to be reviewed by a member of the core team. labels Jul 2, 2025
@stephengillie
Copy link
Collaborator

Merging failed with:

Error:
{
"message": "Base branch was modified. Review and try the merge again.",
"documentation_url": "https://docs.github.com/rest/pulls/pulls#merge-a-pull-request",
"status": "405"
} - Url - Body: {"merge_method":"squash","sha":"3fb3b85763c525619c3aaab1069a12ebf462f385"}

(Automated response - build 1078.)

@stephengillie stephengillie merged commit a246545 into microsoft:master Jul 2, 2025
1 check passed
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Attention This work item needs to be reviewed by a member of the core team. label Jul 2, 2025
@github-actions github-actions bot deleted the issues/267046 branch July 2, 2025 21:00
@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

@wingetbot
Copy link
Collaborator

Publish pipeline succeeded for this Pull Request. Once you refresh your index, this change should be present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ItzLevvie ItzLevvie ItzLevvie approved these changes

@microsoft-github-policy-service microsoft-github-policy-service[bot] microsoft-github-policy-service[bot] approved these changes

@stephengillie stephengillie stephengillie approved these changes

Assignees

@stephengillie stephengillie

Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Moderator-Approved One of the Moderators has reviewed and approved this PR Needs-Manual-Merge The pull request requires a manual merge from a repository maintainer New-Package Publish-Pipeline-Succeeded Validation-Completed Validation passed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Package Request]: BRAdmin Professional 4
4 participants
@Dragon1573 @wingetbot @stephengillie @ItzLevvie