Skip to content

Add RvToolsMerge version 1.4.2 #270687

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sbroenne
Copy link

@sbroenne sbroenne commented Jul 2, 2025

This submission adds RvToolsMerge version 1.4.2 to the Windows Package Manager repository.

Package ID: RvToolsMerge.RvToolsMerge
Version: 1.4.2

Release URL: https://github.com/sbroenne/RvToolsMerge/releases/tag/v1.4.2

I have now fixed the missing ProducCode information in the manifest.

Checklist for Pull Requests

Manifests

  • [ X] Have you checked that there aren't other open pull requests for the same manifest update/change?
  • This PR only modifies one (1) manifest
  • Have you validated your manifest locally with winget validate --manifest <path>?
  • Have you tested your manifest locally with winget install --manifest <path>?
  • Does your manifest conform to the 1.10 schema?

Note: <path> is the directory's name containing the manifest you're submitting.


Microsoft Reviewers: Open in CodeFlow

This submission adds RvToolsMerge version 1.4.2 to the Windows Package Manager repository.

Package ID: RvToolsMerge.RvToolsMerge
Version: 1.4.2

Release URL: https://github.com/sbroenne/RvToolsMerge/releases/tag/v1.4.2
@wingetbot
Copy link
Collaborator

Service Badge  Service Badge  

@wingetbot
Copy link
Collaborator

Validation Pipeline Run WinGetSvc-Validation-65-270687-20250702-1

@wingetbot wingetbot added New-Package Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Validation-Completed Validation passed labels Jul 2, 2025
@microsoft-github-policy-service microsoft-github-policy-service bot enabled auto-merge (squash) July 2, 2025 21:18
@stephengillie
Copy link
Collaborator

Manual Validation ended with:

PS C:\Users\User\Desktop> &"C:\Program Files (x86)\RVToolsMerge\RVToolsMerge.exe" "--version"
CLR: Assert failure(PID 5944 [0x00001738], Thread: 13672 [0x3568]): !AreShadowStacksEnabled() || UseSpecialUserModeApc()
File: D:\a_work\1\s\src\coreclr\vm\threads.cpp:7954 Image:
C:\Program Files (x86)\RVToolsMerge\RVToolsMerge.exe
PS C:\Users\User\Desktop> Get-ARPTable rv

DisplayName : RVToolsMerge
DisplayVersion : 1.4.2.0
Publisher : Stefan Broenner
ProductCode : {198D93B7-15F4-469F-A6D5-E78CEA3BFCD3}
Scope : Machine

PS C:\Users\User\Desktop>

(Automated response - build 1078.)

@stephengillie stephengillie added the Needs-Author-Feedback This needs a response from the author. label Jul 3, 2025
@sbroenne
Copy link
Author

sbroenne commented Jul 3, 2025

@stephengillie: I looked up your CLR: Assert failure and it looks like this is related to your test VM running a very old Windows build: dotnet/runtime#108589.

I can work-arround the issue but this will disable some .NET security protection which I rather would prefer not to.

I have tested RvToolsMerge on a freshly installed & patched Win 11 VM and it works without a problem. It also works flawlessly on other peoples Win 11 VMs.

Microsoft Windows [Version 10.0.22631.5472]
(c) Microsoft Corporation. All rights reserved.

C:\Users\azureuser>rvtoolsmerge --version
1.4.2

@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Attention This work item needs to be reviewed by a member of the core team. and removed Needs-Author-Feedback This needs a response from the author. labels Jul 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Azure-Pipeline-Passed Validation pipeline passed. There may still be manual validation requirements. Needs-Attention This work item needs to be reviewed by a member of the core team. New-Package Validation-Completed Validation passed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants