Parallel Tests #5110
Draft
Parallel Tests #5110
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
colby-swandale
force-pushed
the
colby/parallel-tests
branch
from
b9cc240 to
5d85d79
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5110 +/- ##
===========================================
- Coverage 97.15% 38.58% -58.57%
===========================================
Files 460 460
Lines 9552 10003 +451
===========================================
- Hits 9280 3860 -5420
- Misses 272 6143 +5871 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add worker suffix to search index during tests
colby-swandale
force-pushed
the
colby/parallel-tests
branch
from
7d2ad63 to
152a72a
Compare
colby-swandale
force-pushed
the
colby/parallel-tests
branch
from
32db720 to
5f0590e
Compare
Conflicts: * test/helpers/es_helper.rb * test/models/deletion_test.rb * test/models/pusher_test.rb * test/system/ownership_call_test.rb * test/system/ownership_request_test.rb * test/system/pages_test.rb * test/system/profile_test.rb
These went away earlier this year.
landongrindheim
force-pushed
the
colby/parallel-tests
branch
from
2294554 to
6d8fa30
Compare
We don't need to call `.reindex` twice, nor do we need to disable callbacks twice.
Searchkick suggests using setup/teardown to handle callbacks. Rather than adding these to each file that's including the module, I'm handling callbacks via hooks.
Our tests were failing with 404s around index names, which included timestamps for some reason. Since the constant is no longer used, I've removed it as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's this about?
Currently we run our tests in serial, leading to somewhat slow test times in Dev & Github Actions even though we have fast machines.
This Pul Request tweaks our test setup to enable parallel tests, and updates our tests to work correctly with the new changes.