Skip to content

Move link job to separate queue. #5602

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move link job to separate queue. #5602

wants to merge 1 commit into from

Conversation

simi
Copy link
Member

@simi simi commented Apr 11, 2025

No description provided.

Copy link

codecov bot commented Apr 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.11%. Comparing base (46ff0a3) to head (8aa257c).
Report is 16 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5602   +/-   ##
=======================================
  Coverage   97.11%   97.11%           
=======================================
  Files         454      454           
  Lines        9441     9443    +2     
=======================================
+ Hits         9169     9171    +2     
  Misses        272      272           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@colby-swandale colby-swandale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would very much like to see us take a page out of the sidekiq handbook and name our job queues after their expected latency, ie: within_30_seconds, within_5_minutes, etc. It provides much more clear intent on what our expectations are and allows us to set monitoring rules much easier.

@github-project-automation github-project-automation bot moved this from Ready to In Progress in RubyGems.org Pull Requests Apr 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

3 participants