POC implementation for task_group dynamic dependencies - part 1 - task_tracker #1682
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
13 tasks
kboyarinov
commented
May 16, 2025
| @@ -87,6 +87,9 @@ class function_task : public task_handle_task { | |||
| d1::task* execute(d1::execution_data& ed) override { | |||
| __TBB_ASSERT(ed.context == &this->ctx(), "The task group context should be used for all tasks"); | |||
| task* res = task_ptr_or_nullptr(m_func); | |||
| #if __TBB_PREVIEW_TASK_GROUP_EXTENSIONS | |||
| this->complete_task(); | |||
There was a problem hiding this comment.
No-op in this part, would be used in part 2 for bypassing the successor task
13 tasks
vossmjp
reviewed
Jun 27, 2025
| @@ -1,5 +1,5 @@ | |||
| /* | |||
| Copyright (c) 2020-2024 Intel Corporation | |||
| Copyright (c) 2020-2025 Intel Corporation | |||
There was a problem hiding this comment.
Suggested change
| Copyright (c) 2020-2025 Intel Corporation | |
| Copyright (c) 2020-2024 Intel Corporation | |
| Copyright (c) 2025 UXL Foundation contributors |
|
|
||
| if (m_state.compare_exchange_strong(current_state, new_state)) { | ||
| // Reserve a task co-ownership for dynamic_state | ||
| new_state->reserve(); |
There was a problem hiding this comment.
Is it possible that two trackers T1 and T2 to the same handle H are constructor concurrently? And if so, what if T2 is destroyed before T1 finishes its call to get_dynamic_state. Is it possible for the destruction of T2 to delete the task_dynamic_state before T1 has reserved it? I think T1 could succeed at exchanging a newly create state, T2 could see it and reserve and release, before T1 reserves.
| @@ -1222,3 +1222,124 @@ TEST_CASE("task_handle cannot be scheduled into other task_group of the same con | |||
| } | |||
|
|
|||
| #endif // TBB_USE_EXCEPTIONS | |||
|
|
|||
| #if __TBB_PREVIEW_TASK_GROUP_EXTENSIONS | |||
| TEST_CASE("test task_tracker") { | |||
There was a problem hiding this comment.
Case that I think are missing:
- is concurrent creation / destruction of trackers to same handle
- creation of tracker to deferred task but handle is destroyed without being run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
First part of POC implementation for task_group dynamic dependencies.
Design described in the RFC #1664
This PR extends the
task_grouptasks with the dynamic state, that currently allows tracking the progress of the task using the new objecttask_tracker.In the future parts, dynamic state of the task would be reused for setting and transferring dependencies between tasks.
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information