UA SHOULD guidance for roles outside of required a11y parent role #2562
Conversation
✅ Deploy Preview for wai-aria ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
|
Oh, good grief. Prettier is running wild after its recent update. Please review the initial commit only. |
There was a problem hiding this comment.
Looks good to me! @pkra am I the third reviewer, want to land?
|
This seems to be the cleanest prettier commit. Merging this seems like the best chance to clean up these unexpected changes. |
Hmmm I'm not convinced that we shouldn't merge this instead: #2568 I guess we can talk about it tomorrow at the editors meeting? The PR you are concerned about at least is from Rahim, who I think would make time to clean it up even if that means making a new PR entirely. |
My reasoning is that this prettier commit does not touch anything from the preceding commit. The prettier commit in #2568 touches the hack used to trigger a build. The cleanest way would be a PR that runs prettier - but that should generate the identical commit as the prettier commit here (as we've seen in the past). |
pkra
force-pushed
the
add-ua-should-for-a11y-parent-role
branch
from
a12b8a4 to
ab43d35
Compare
) SHA: 6e23814 Reason: push, by pkra Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Replicates #2418 by @rahimabdi
Closes #2012, closes #2418
This PR adds additional user agent guidance for how orphan roles SHOULD be treated outside of the context of a required accessibility parent role.
Preview | Diff