Skip to content

Uses custom action to run prettier on PRs and on pushes to main #2564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

daniel-montalvo
Copy link
Contributor

@daniel-montalvo daniel-montalvo commented Jun 20, 2025

Resolves #2470

@daniel-montalvo daniel-montalvo requested a review from pkra June 20, 2025 14:15
Copy link

netlify bot commented Jun 20, 2025

Deploy Preview for wai-aria ready!

Name Link
🔨 Latest commit 2e8c79d
🔍 Latest deploy log https://app.netlify.com/projects/wai-aria/deploys/68556cf4aab3d10008a251ae
😎 Deploy Preview https://deploy-preview-2564--wai-aria.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@daniel-montalvo daniel-montalvo linked an issue Jun 20, 2025 that may be closed by this pull request
node-version: 'lts/*'

- name: Install Prettier
run: npm install --global prettier
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would specify a version here. Otherwise there's a chance the two PRs using different versions get merge conflicts.

echo "changed=true" >> "$GITHUB_OUTPUT"
else
echo "changed=false" >> "$GITHUB_OUTPUT"
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know that kind of scripting worked. I didn't test it but it looks good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

revisit prettier automation
2 participants