Skip to content

perf: prepare module outgoings for code splitting #10931

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

perf: prepare module outgoings for code splitting #10931

wants to merge 5 commits into from

Conversation

LingyuCoder
Copy link
Contributor

@LingyuCoder LingyuCoder commented Jul 7, 2025 •
edited
Loading

Summary

Prepare module outgoings for code splitting while generating chunk graph.

Before: 2.8s
image

After: 1.7s
image
image

Related links

Checklist

  • Tests updated (or not required).
  • Documentation updated (or not required).

@LingyuCoder LingyuCoder requested a review from JSerFeng July 7, 2025 08:51
@netlify Netlify
Copy link

netlify bot commented Jul 7, 2025 •
edited
Loading

✅ Deploy Preview for rspack canceled.

Name Link
🔨 Latest commit 6814a13
🔍 Latest deploy log https://app.netlify.com/projects/rspack/deploys/686bb0e389104a0008189e5f

@github-actions github-actions bot added release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack. labels Jul 7, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 7, 2025 •
edited
Loading

📦 Binary Size-limit

Comparing binary size with Commit: fix: js api module readable identifier (#10929) by Cong-Cong Pan

❌ Size increased by 33.00KB from 59.94MB to 59.98MB (⬆️0.05%)

@codspeed-hq CodSpeed HQ
Copy link

codspeed-hq bot commented Jul 7, 2025 •
edited
Loading

CodSpeed Performance Report

Merging #10931 will degrade performances by 17.86%

Comparing perf/prepare-outgoings (6814a13) with main (c3e3de0)

Summary

❌ 1 regressions
✅ 15 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
❌ rust@build_chunk_graph_parallel 75.6 ms 92 ms -17.86%

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JSerFeng JSerFeng Awaiting requested review from JSerFeng

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
release: performance release: performance related release(mr only) team The issue/pr is created by the member of Rspack.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@LingyuCoder