-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Implement new hashing #7259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Implement new hashing #7259
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IGI-111
previously approved these changes
Jul 4, 2025
IGI-111
approved these changes
Jul 7, 2025
zees-dev
approved these changes
Jul 11, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice; LGTM 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR implements new hashing, as explained in the tracking issue #7256. New hashing is an opt-in experimental feature with the feature flag
new_hashing
.The new hashing hashes lengths as prefix to the content hash for the following built-in and
std
types:str
)[T; N]
)std::vec::Vec<T>
std::bytes::Bytes
Additionally, the PR adds missing
Hash
implementations, "old", without lengths, and new for:str[N]
)raw_slice
)Some of the
std
types that use the above types internally for storing their content still hash only the content, without the length prefix of the container. The reason for this is that:A typical example would be
std::b512::B512
where, same tob256
we want to hash only the content.Notice that this does not cause the security issue described in #7256.
Here is the complete list of those types:
std::crypto::secp256k1::Secp256k1
std::crypto::secp256r1::Secp256r1
std::crypto::message::Message
std::crypto::public_key::PublicKey
std::b512::B512
Some of the implementations differ based on the combination of
const_generics
andnew_hashing
features. Therefore, on CI, we have a step testing both experimental features together.Additionally, the PR:
const_generics
experimental feature to CI.Checklist
Breaking*
orNew Feature
labels where relevant.