Make the remaining bundle files typed: true
#20128
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeMcQuaid
approved these changes
Jun 17, 2025
|
@issyl0 Fixed |
|
I did this and then put my laptop away for a few hours. I'll get back to this probably when it's dark! |
issyl0
force-pushed
the
some-bundle-files-werent-typed-at-all
branch
from
be257bc to
a37ed04
Compare
MikeMcQuaid
reviewed
Jun 19, 2025
| @@ -22,41 +26,42 @@ def self.run(*args, global: false, file: nil, subcommand: "", services: false, c | |||
| # Store the old environment so we can check if things were already set | |||
| # before we start mutating it. | |||
| old_env = ENV.to_h | |||
| new_env = T.cast(ENV, Superenv) | |||
There was a problem hiding this comment.
@issyl0 Seems like this doesn't work as expected: https://github.com/Homebrew/brew/actions/runs/15756327267/job/44412600178?pr=20128#step:5:324
CC @Bo98 who might have an idea on how to do this with ENV
MikeMcQuaid
approved these changes
Jun 19, 2025
auto-merge was automatically disabled
June 20, 2025 08:02
Pull request was converted to draft
issyl0
added a commit
that referenced
this pull request
Jun 20, 2025
- The last remaining one is `exec` but that's a bit more involved (#20128 (comment)).
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
brew stylewith your changes locally?brew typecheckwith your changes locally?brew testswith your changes locally?typed: strictin all (non-package) files in Homebrew organisation #17297.