Skip to content

ada-url: install adaparse tool by default #227639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

abelcha
Copy link

@abelcha abelcha commented Jun 20, 2025

  • Enable installation of the adaparse command-line tool by default
  • Add test to verify adaparse tool installation

This change adds the adaparse command-line tool to the default installation of ada-url. The tool is useful for parsing and validating URLs from the command line.

The change is implemented by:

  1. Adding -DADA_TOOLS=ON to the CMake arguments
  2. Adding a test to verify the tool is installed and working

Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot added the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 21, 2025
@chenrui333 chenrui333 force-pushed the ada-url-enable-adaparse branch from 51db553 to eaf8e92 Compare June 21, 2025 02:20
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jun 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants