Skip to content

Fix makepkg on macOS by adding an older version of fakeroot #229375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Fix makepkg on macOS by adding an older version of fakeroot #229375

wants to merge 2 commits into from
+49 −1

Conversation

AdityaGarg8
Copy link

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing HOMEBREW_NO_INSTALL_FROM_API=1 brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. new formula PR adds a new formula to Homebrew/homebrew-core labels Jul 8, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Jul 8, 2025
@AdityaGarg8 AdityaGarg8 closed this Jul 8, 2025
@AdityaGarg8 AdityaGarg8 reopened this Jul 8, 2025
@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. and removed automerge-skip `brew pr-automerge` will skip this pull request labels Jul 8, 2025
@AdityaGarg8
Copy link
Author

I am unable to understand whats wrong with commit style here

@AdityaGarg8
Copy link
Author

tap syntax also seems to be false positive error

@SMillerDev
Copy link
Member

Is this issue reported upstream? Because that should be done before we merge this.

@AdityaGarg8
Copy link
Author

Is this issue reported upstream? Because that should be done before we merge this.

#202729

https://forum.manjaro.org/t/fakeroot-version-1-35-hangs-even-directly-from-bash-cant-upgrade-packages/166355

@SMillerDev
Copy link
Member

So it seems nobody ever reported it, could you do that?

@AdityaGarg8
Copy link
Author

So it seems nobody ever reported it, could you do that?

I can have a look. Working with Debian devs is a PITA tbh. Anyways, till it's fixed, what shall be the options?

@carlocab
Copy link
Member

carlocab commented Jul 9, 2025

tap syntax also seems to be false positive error

It is not. The fakeroot@1.31 formula file is missing a .rb extension.

@AdityaGarg8 AdityaGarg8 closed this Jul 9, 2025
@AdityaGarg8 AdityaGarg8 reopened this Jul 9, 2025
@AdityaGarg8
Copy link
Author

tap syntax also seems to be false positive error

It is not. The fakeroot@1.31 formula file is missing a .rb extension.

Ah thanks for noticing. Fixed.

@AdityaGarg8
Copy link
Author

So it seems nobody ever reported it, could you do that?

I looked into this, and this requires me to have an installation of Debian to file a bug report. Honestly its too much of a hassle that I'd rather bisect the faulty commit.

@AdityaGarg8
fakeroot@1.31 (New formula)
a2b00d2 
Fakeroot starting from version 1.35 hangs on macOS and has not been fixed
for a long time. Add the older supported version 1.31 formula for macOS users
@AdityaGarg8
make makepkg depend on older fakeroot on macos
b5411b8 
makepkg needs fakeroot to work. On macOS, the version of fakeroot working
atm is 1.31, which is not the latest version. This commit makes makepkg
depend on fakeroot@1.31 on macOS
@github-actions github-actions bot added automerge-skip `brew pr-automerge` will skip this pull request alias and removed autosquash Automatically squash pull request commits according to Homebrew style. labels Jul 9, 2025
carlocab
carlocab requested changes Jul 9, 2025
View reviewed changes
Copy link
Member

@carlocab carlocab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I looked into this, and this requires me to have an installation of Debian to file a bug report. Honestly its too much of a hassle that I'd rather bisect the faulty commit.

I'm afraid we'll have to wait until this is reported to Debian before we merge this. You don't have to be the one to do it, but someone has to before we apply this workaround here, or else we risk just carrying this workaround indefinitely.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlocab carlocab carlocab requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
alias automerge-skip `brew pr-automerge` will skip this pull request new formula PR adds a new formula to Homebrew/homebrew-core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AdityaGarg8 @SMillerDev @carlocab