Skip to content

readline: apply patch #229603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 11, 2025
Merged

readline: apply patch #229603

merged 2 commits into from
Jul 11, 2025
+15 −8

Conversation

YuyangisCoding
Copy link
Contributor

applied patch for #229296

@github-actions github-actions bot added autosquash Automatically squash pull request commits according to Homebrew style. long dependent tests Set a long timeout for dependent testing labels Jul 10, 2025
@github-actions GitHub Actions
Copy link
Contributor

Thanks for contributing to Homebrew! 🎉 It looks like you're having trouble with a CI failure. See our contribution guide for help. You may be most interested in the section on dealing with CI failures. You can find the CI logs in the Checks tab of your pull request.

@fxcoudert
Copy link
Member

fxcoudert commented Jul 10, 2025 •
edited
Loading

Thank you for proposing this patch! Needs some style changes:

  Taps/homebrew/homebrew-core/Formula/r/readline.rb:19:3: C: [Correctable] Layout/IndentationWidth: Use 2 (not 4) spaces for indentation.
        url "https://lists.gnu.org/archive/html/bug-readline/2025-07/txtTYu28QVKRX.txt"
    ^^^^
  Taps/homebrew/homebrew-core/Formula/r/readline.rb:35:3: C: [Correctable] FormulaAudit/ComponentsOrder: livecheck (line 35) should be put before patch (line 18)
    livecheck do ...
    ^^^^^^^^^^^^

Also, please make sure your commit message is readline: add patch

@fxcoudert fxcoudert added the CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. label Jul 10, 2025
@carlocab carlocab changed the title fix readline 8.3 readline: apply patch Jul 10, 2025
@YuyangisCoding
Copy link
Contributor Author

Fixed the style.

@iMichka
Copy link
Member

iMichka commented Jul 10, 2025 •
edited
Loading

Taps/homebrew/homebrew-core/Formula/r/readline.rb:71:3: C: [Correctable] FormulaAudit/ComponentsOrder: no_autobump! (line 71) should be put before patch (line 66)

Can you reorganise the code? This should be good to go after that.

@SMillerDev SMillerDev enabled auto-merge July 11, 2025 09:02
@github-actions github-actions bot removed the autosquash Automatically squash pull request commits according to Homebrew style. label Jul 11, 2025
@fxcoudert fxcoudert added the ready to merge PR can be merged once CI is green label Jul 11, 2025
@fxcoudert
Copy link
Member

Should be good now.

@fxcoudert fxcoudert added the CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. label Jul 11, 2025
@carlocab carlocab disabled auto-merge July 11, 2025 13:21
@github-actions GitHub Actions
Copy link
Contributor

🤖 An automated task has requested bottles to be published to this PR.

Caution

Please do not push to this PR branch before the bottle commits have been pushed, as this results in a state that is difficult to recover from. If you need to resolve a merge conflict, please use a merge commit. Do not force-push to this PR branch.

@github-actions github-actions bot added the CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. label Jul 11, 2025
@BrewTestBot BrewTestBot enabled auto-merge July 11, 2025 16:45
@BrewTestBot BrewTestBot added this pull request to the merge queue Jul 11, 2025
Merged via the queue into Homebrew:main with commit 9d1b3f1 Jul 11, 2025
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chenrui333 chenrui333 chenrui333 approved these changes

@fxcoudert fxcoudert fxcoudert approved these changes

@carlocab carlocab carlocab approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees
No one assigned
Labels
CI-no-fail-fast Continue CI tests despite failing GitHub Actions matrix builds. CI-published-bottle-commits The commits for the built bottles have been pushed to the PR branch. CI-skip-recursive-dependents Pass --skip-recursive-dependents to brew test-bot. long dependent tests Set a long timeout for dependent testing ready to merge PR can be merged once CI is green
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@YuyangisCoding @fxcoudert @iMichka @chenrui333 @carlocab @BrewTestBot