Restore binary compatibility of year() and monthNumber()
#548
Conversation
| @@ -30,7 +30,7 @@ allprojects { | |||
| kotlinOptions.freeCompilerArgs += "-version" | |||
| } | |||
| tasks.withType<org.jetbrains.kotlin.gradle.tasks.KotlinJvmCompile>().configureEach { | |||
| compilerOptions { freeCompilerArgs.add("-Xjvm-default=disable") } | |||
| compilerOptions { freeCompilerArgs.add("-Xjvm-default=all-compatibility") } | |||
There was a problem hiding this comment.
Looks strange that we need to enable this mode. Have we ever shipped the library with jvm-default mode other than "disable" (which was default in previous kotlin versions)?
There was a problem hiding this comment.
No, we haven't. The purpose of this PR is to be able to replace DateTimeFormatBuilder$WithDate$DefaultImpls with a custom one, containing the removed static methods. Without turning on jvm-default, the annotation @JvmDefaultWithoutCompatibility has no effect, which means DateTimeFormatBuilder$WithDate$DefaultImpls gets generated by the compiler.
We could keep the all-compatibility flag to make the annotation work, mark everything with the annotation, and write all DefaultImpls by ourselves, but I don't see the point, given that we'll want to migrate anyway.
dkhalanskyjb
force-pushed
the
dkhalanskyjb/restore-missing-static-default-method
branch
from
bf56673 to
fb6c423
Compare
dkhalanskyjb
deleted the
dkhalanskyjb/restore-missing-static-default-method
branch
Fixes #545