Skip to content

feat: upgrade da manifest 1.4 #14064

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

feat: upgrade da manifest 1.4 #14064

wants to merge 1 commit into from

Conversation

jayzhang
Copy link
Member

No description provided.

github-advanced-security[bot]
github-advanced-security bot found potential problems May 28, 2025
View reviewed changes
packages/manifest/download.js
@@ -13,6 +13,7 @@
const zipPath = path.join(tempDir, "live.zip");

console.log(`Downloading zip to ${zipPath}`);
process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";

Check failure

Code scanning / CodeQL

Disabling certificate validation High

Disabling certificate validation is strongly discouraged.

Copilot Autofix

AI 2 months ago

To fix the issue, we will remove the line process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0" and ensure that certificate validation is enabled for all HTTPS requests. If there is a specific reason for disabling certificate validation (e.g., self-signed certificates in a development environment), it should be handled in a more controlled and explicit manner, such as using a custom HTTPS agent with proper configuration.

Suggested changeset 1
packages/manifest/download.js

Autofix patch

Autofix patch
Run the following command in your local git repository to apply this patch
cat << 'EOF' | git apply
diff --git a/packages/manifest/download.js b/packages/manifest/download.js
--- a/packages/manifest/download.js
+++ b/packages/manifest/download.js
@@ -15,3 +15,3 @@
   console.log(`Downloading zip to ${zipPath}`);
-  process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";
+
   const res = await fetch(url);
EOF
@@ -15,3 +15,3 @@
console.log(`Downloading zip to ${zipPath}`);
process.env.NODE_TLS_REJECT_UNAUTHORIZED = "0";

const res = await fetch(url);
Copilot is powered by AI and may make mistakes. Always verify output.
@codecov Codecov
Copy link

codecov bot commented May 28, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.99%. Comparing base (2b18751) to head (ae40e84).
Report is 1 commits behind head on dev.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##              dev   #14064   +/-   ##
=======================================
  Coverage   89.99%   89.99%           
=======================================
  Files         646      646           
  Lines       38683    38683           
  Branches     7626     7659   +33     
=======================================
  Hits        34814    34814           
  Misses       1755     1755           
  Partials     2114     2114
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jayzhang jayzhang closed this Jun 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tecton tecton

@llhmm01 llhmm01

@wh-alice wh-alice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jayzhang