fix(go/adbc): Forward SQLSTATE and vendor code #2801
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felipecrv
commented
May 8, 2025
| // If there are no details, but we have a `VendorCode`, let's override | ||
| // `vendor_code` and not populate `private_data` with the error details. | ||
| if numDetails == 0 && adbcError.VendorCode != 0 && adbcError.VendorCode != C.ADBC_ERROR_VENDOR_CODE_PRIVATE_DATA { | ||
| err.vendor_code = C.int(adbcError.VendorCode) |
There was a problem hiding this comment.
@zeroshade if you are OK with this approach I will change the go.tmpl file and make regenerate.
There was a problem hiding this comment.
This looks good to me. I wonder if there's any good way we could add a test for this (perhaps using the sqlite driver or otherwise?)
felipecrv
force-pushed
the
sqlstate-and-vendor
branch
from
fe717e5 to
97f831f
Compare
|
I applied the fix to my fork, so this will be another issue/PR I procrastinate on because of my own prioritization requirements. I applied the change to the template and re-generated the sources. What is missing (and is more time-consuming) is adding the tests. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2800