-
Notifications
You must be signed in to change notification settings - Fork 143
feat(python/adbc_driver_manager): support more APIs sans PyArrow #2839
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'm also curious if this approach to extensibility is "good enough". I haven't added anything that looks for entry points (to allow external packages to register more backends). |
I think just getting the structure is great...registering stuff might just never come up. |
f6a4dac
to
68bcd06
Compare
@pytest.mark.xfail(raises=dbapi.NotSupportedError) | ||
def test_get_table_schema(sqlite: dbapi.Connection) -> None: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is only because it seems polars can't currently import a schema by itself. I still need to go raise an issue/PR on their side
@zeroshade would you be able to review? |
I'm planning on cutting a release soon whether this is reviewed or not, but I'd like to get this reviewed if possible so that henryharbeck and other users don't have to wait another two months for the next release |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, no comments.
Fixes #2827.