chore: add codespell #2864

daipom · 2025-05-26T15:07:40Z

daipom · 2025-05-26T15:08:35Z

$ pre-commit run codespell --all-files
codespell................................................................Failed
- hook id: codespell
- exit code: 65

c/driver/postgresql/connection.cc:184: constraits ==> constraints
ci/linux-packages/debian/control:171: gir ==> git
ci/linux-packages/debian/control:220: gir ==> git
csharp/src/Drivers/Apache/Hive2/DecimalUtility.cs:172: fron ==> from, front
CHANGELOG.md:350: Inital ==> Initial
CHANGELOG.md:693: consisent ==> consistent
LICENSE.txt:1286: Collet ==> Collect
c/driver/postgresql/copy/postgres_copy_test_common.h:24: genereated ==> generated
csharp/src/Apache.Arrow.Adbc/C/CAdbcConnection.cs:37: unintialized ==> uninitialized
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:62: ouput ==> output
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:124: Ditionary ==> Dictionary
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:198: formated ==> formatted
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:214: formated ==> formatted
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:230: formated ==> formatted
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:307: statment ==> statement
docs/source/python/recipe/flight_sql.rst:22: againt ==> against
rust/core/src/ffi/types.rs:65: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:77: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:89: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:116: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:129: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:133: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:673: transfered ==> transferred
csharp/test/Drivers/Apache/Spark/SparkConnectionTest.cs:48: exeption ==> exception, exemption
csharp/test/Drivers/Apache/Spark/SparkConnectionTest.cs:49: exeption ==> exception, exemption
csharp/test/Drivers/Databricks/DatabricksConnectionTest.cs:55: exeption ==> exception, exemption
csharp/test/Drivers/Databricks/DatabricksConnectionTest.cs:56: exeption ==> exception, exemption
docs/source/driver/snowflake.rst:294: bandwith ==> bandwidth
go/adbc/driver/flightsql/flightsql_statement.go:429: returnes ==> returns
r/adbcsnowflake/README.md:77: ges ==> goes, guess
c/cmake_modules/BuildUtils.cmake:228: thirdparty ==> third party, third-party
c/validation/adbc_validation_util.cc:323: occured ==> occurred
csharp/test/Drivers/Databricks/DateTimeValueTests.cs:42: Timstamp ==> Timestamp
dev/bench/README.md:42: passsword ==> password
rust/driver/snowflake/src/duration.rs:49: eror ==> error
c/driver/postgresql/copy/reader.h:867: chlidren ==> children
csharp/src/Apache.Arrow.Adbc/C/CAdbcDatabase.cs:39: unintialized ==> uninitialized
go/adbc/adbc.go:647: returnes ==> returns
ci/linux-packages/debian/rules:29: gir ==> git
go/adbc/driver/internal/driverbase/connection.go:372: implementor ==> implementer
java/driver/flight-sql/src/test/java/org/apache/arrow/adbc/driver/flightsql/DetailsTest.java:50: AfterAll ==> after all
java/driver/flight-sql/src/test/java/org/apache/arrow/adbc/driver/flightsql/DetailsTest.java:95: AfterAll ==> after all
java/driver/flight-sql/src/test/java/org/apache/arrow/adbc/driver/flightsql/DetailsTest.java:96: afterAll ==> after all
java/driver/flight-sql/src/test/java/org/apache/arrow/adbc/driver/flightsql/GetObjectsTests.java:61: AfterAll ==> after all
java/driver/flight-sql/src/test/java/org/apache/arrow/adbc/driver/flightsql/GetObjectsTests.java:295: AfterAll ==> after all
rust/core/src/lib.rs:56: langages ==> languages
csharp/test/Drivers/Apache/Impala/Resources/impalaconfig.json:8: schem ==> scheme
docs/source/faq.rst:177: tranposing ==> transposing
docs/source/format/specification.rst:248: retrive ==> retrieve
go/adbc/driver/snowflake/driver_test.go:2075: exepected ==> expected
go/adbc/driver/snowflake/driver_test.go:2093: exepected ==> expected
ci/linux-packages/debian/libadbc-glib-dev.install:5: gir ==> git
csharp/src/Apache.Arrow.Adbc/C/CAdbcPartitions.cs:63: unintialized ==> uninitialized
csharp/src/Drivers/Apache/Impala/README.md:68: specifed ==> specified
csharp/src/Drivers/Apache/Impala/README.md:106: standar ==> standard
rust/README.md:51: trough ==> through
.github/workflows/packaging.yml:414: fpr ==> for, far, fps
c/driver/postgresql/copy/writer.h:729: limtiations ==> limitations
ci/linux-packages/debian/libadbc-arrow-glib-dev.install:5: gir ==> git
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:35: defintion ==> definition
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:140: defintion ==> definition
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:153: defintion ==> definition
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:490: STUCT ==> STRUCT
csharp/src/Drivers/Apache/Spark/README.md:64: specifed ==> specified
csharp/test/Drivers/Databricks/StatementTests.cs:437: mintues ==> minutes
csharp/test/Drivers/Interop/Snowflake/SnowflakeTestingUtils.cs:169: occured ==> occurred
csharp/test/Drivers/Interop/Snowflake/SnowflakeTestingUtils.cs:169: resouce ==> resource
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriver.cs:40: unintialized ==> uninitialized
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriver.cs:47: unintialized ==> uninitialized
csharp/test/Drivers/Apache/Common/ClientTests.cs:214: timout ==> timeout
csharp/test/Drivers/Apache/Common/DateTimeValueTests.cs:61: Timstamp ==> Timestamp
csharp/test/Drivers/Apache/Common/DateTimeValueTests.cs:83: Timstamp ==> Timestamp
docs/source/driver/postgresql.rst:42: accellerate ==> accelerate
docs/source/driver/postgresql.rst:351: posgresql ==> postgresql
go/adbc/driver/internal/driverbase/rotating_file_writer.go:260: exising ==> existing
go/adbc/driver/internal/driverbase/rotating_file_writer.go:293: lexigraphically ==> lexicographically
go/adbc/driver/snowflake/connection.go:190: hasTables ==> hashtables
go/adbc/driver/snowflake/connection.go:195: hasTables ==> hashtables
go/adbc/driver/snowflake/connection.go:204: hasTables ==> hashtables
.github/workflows/r-extended.yml:92: verions ==> versions
c/cmake_modules/DefineOptions.cmake:90: CHECKIN ==> CHECKING, CHECK IN
c/cmake_modules/DefineOptions.cmake:160: Thirdparty ==> Third party, Third-party
c/driver/postgresql/result_helper.h:113: desctructor ==> destructor
ci/linux-packages/yum/apache-arrow-adbc.spec.in:284: gir ==> git
ci/linux-packages/yum/apache-arrow-adbc.spec.in:333: gir ==> git
csharp/src/Apache.Arrow.Adbc/C/CAdbcStatement.cs:47: unintialized ==> uninitialized
csharp/src/Client/AdbcConnection.cs:45: Intializes ==> Initializes
csharp/src/Client/AdbcConnection.cs:56: Intializes ==> Initializes
docs/source/driver/flight_sql.rst:226: reponse ==> response
go/adbc/driver/snowflake/bulk_ingestion.go:23: flate ==> flat
go/adbc/driver/snowflake/bulk_ingestion.go:65: flate ==> flat
go/adbc/driver/snowflake/bulk_ingestion.go:88: bandwith ==> bandwidth
go/adbc/driver/snowflake/bulk_ingestion.go:285: COPYs ==> copies
go/adbc/driver/snowflake/bulk_ingestion.go:491: propogate ==> propagate
go/adbc/driver/snowflake/bulk_ingestion.go:561: recieved ==> received
go/adbc/driver/snowflake/bulk_ingestion.go:580: COPYs ==> copies
rust/driver/dummy/tests/driver_exporter_dummy.rs:19: trough ==> through
go/adbc/driver/snowflake/statement.go:470: returnes ==> returns
go/adbc/drivermgr/arrow-adbc/adbc.h:305: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:862: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:885: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:923: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:962: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:990: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:994: unintialized ==> uninitialized
go/adbc/ext.go:68: Implementors ==> Implementers
rust/core/src/driver_manager.rs:157: droped ==> dropped
ci/scripts/go_license.sh:19: thirdparty ==> third party, third-party
csharp/src/Apache.Arrow.Adbc/AdbcConnection11.cs:356: statistcs ==> statistics
csharp/src/Drivers/Apache/Hive2/README.md:70: specifed ==> specified
csharp/test/Drivers/Interop/FlightSql/readme.md:36: compatibilty ==> compatibility
csharp/test/Drivers/Interop/FlightSql/readme.md:62: resutls ==> results
go/adbc/driver/bigquery/statement.go:572: Unparseable ==> Unparsable
go/adbc/sqldriver/driver.go:85: re-use ==> reuse
go/adbc/sqldriver/driver.go:117: re-use ==> reuse
python/adbc_driver_bigquery/LICENSE.txt:1286: Collet ==> Collect
c/include/arrow-adbc/adbc.h:305: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:862: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:885: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:923: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:962: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:990: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:994: unintialized ==> uninitialized
csharp/src/Drivers/Apache/Thrift/BitmapUtilities.cs:53: remaing ==> remaining
csharp/test/Drivers/BigQuery/AuthenticationTests.cs:65: behvior ==> behavior
r/adbcdrivermanager/src/options.cc:84: suppported ==> supported
r/adbcdrivermanager/src/options.cc:106: suppported ==> supported
r/adbcdrivermanager/src/options.cc:127: suppported ==> supported
c/cmake_modules/AdbcDefines.cmake:68: CHECKIN ==> CHECKING, CHECK IN
c/driver/postgresql/bind_stream.h:218: Paramter ==> Parameter
go/adbc/driver/internal/driverbase/database.go:61: te ==> the, be, we, to
go/adbc/driver/internal/driverbase/database.go:67: te ==> the, be, we, to
go/adbc/driver/internal/driverbase/database.go:323: te ==> the, be, we, to
go/adbc/driver/internal/driverbase/database.go:324: te ==> the, be, we, to
c/driver/postgresql/postgres_type.h:214: posgresql ==> postgresql
csharp/test/Drivers/Interop/FlightSql/DriverTests.cs:46: caseSenstive ==> case-sensitive
csharp/test/Drivers/Interop/FlightSql/DriverTests.cs:55: caseSenstive ==> case-sensitive
dev/release/verify-release-candidate.sh:950: enviroment ==> environment

daipom · 2025-05-26T15:21:06Z

There seems to be a certain effect on typos on the code.
However, some are annoying false positives, and we will likely continue to encounter similar false positives in the future.

java/driver/flight-sql/src/test/java/org/apache/arrow/adbc/driver/flightsql/DetailsTest.java:50: AfterAll ==> after all
.github/workflows/packaging.yml:414: fpr ==> for, far, fps
go/adbc/driver/snowflake/connection.go:190: hasTables ==> hashtables
go/adbc/driver/snowflake/bulk_ingestion.go:580: COPYs ==> copies
go/adbc/driver/internal/driverbase/database.go:61: te ==> the, be, we, to
...

For files under docs/, it works very well.

docs/source/python/recipe/flight_sql.rst:22: againt ==> against
docs/source/driver/snowflake.rst:294: bandwith ==> bandwidth
docs/source/faq.rst:177: tranposing ==> transposing
docs/source/format/specification.rst:248: retrive ==> retrieve
docs/source/driver/postgresql.rst:42: accellerate ==> accelerate
docs/source/driver/postgresql.rst:351: posgresql ==> postgresql
docs/source/driver/flight_sql.rst:226: reponse ==> response

There are two possible approaches.

A: Limit it to specific areas, such as files under docs/ or *.md.
B: Apply it to as broadly as possible, and make an effort to configure exclusion words.

kou

It seems that there are useful results in not docs/ directory too. For example:

c/cmake_modules/AdbcDefines.cmake:68: CHECKIN ==> CHECKING, CHECK IN

So I think that maintaining ignore words instead of limiting to docs/ is better.

.pre-commit-config.yaml

daipom · 2025-05-28T05:32:10Z

There are two possible approaches.

* A: Limit it to specific areas, such as files under `docs/` or `*.md`.
* B: Apply it to as broadly as possible, and make an effort to configure exclusion words.

I will organize this PR in the direction of B.
Please let me know if you have any other opinions.

kou · 2025-05-28T05:57:16Z

It seems that there are useful results in not docs/ directory too. For example:
c/cmake_modules/AdbcDefines.cmake:68: CHECKIN ==> CHECKING, CHECK IN
So I think that maintaining ignore words instead of limiting to docs/ is better.

Sorry. The example is wrong. It's a false positive result...

This is an useful result:

c/include/arrow-adbc/adbc.h:305: unintialized ==> uninitialized

daipom · 2025-05-28T06:26:24Z

There are two possible approaches.
* A: Limit it to specific areas, such as files under `docs/` or `*.md`.
* B: Apply it to as broadly as possible, and make an effort to configure exclusion words.
I will organize this PR in the direction of B. Please let me know if you have any other opinions.

Done.

I believe the current detections are true positives.
I'll fix them in other PRs, then rebase this.

Sorted result:

.github/workflows/r-extended.yml:92: verions ==> versions
c/driver/postgresql/bind_stream.h:218: Paramter ==> Parameter
c/driver/postgresql/connection.cc:184: constraits ==> constraints
c/driver/postgresql/copy/postgres_copy_test_common.h:24: genereated ==> generated
c/driver/postgresql/copy/reader.h:867: chlidren ==> children
c/driver/postgresql/copy/writer.h:729: limtiations ==> limitations
c/driver/postgresql/postgres_type.h:214: posgresql ==> postgresql
c/driver/postgresql/result_helper.h:113: desctructor ==> destructor
c/include/arrow-adbc/adbc.h:305: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:862: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:885: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:923: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:962: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:990: unintialized ==> uninitialized
c/include/arrow-adbc/adbc.h:994: unintialized ==> uninitialized
c/validation/adbc_validation_util.cc:323: occured ==> occurred
CHANGELOG.md:350: Inital ==> Initial
CHANGELOG.md:693: consisent ==> consistent
csharp/src/Apache.Arrow.Adbc/AdbcConnection11.cs:356: statistcs ==> statistics
csharp/src/Apache.Arrow.Adbc/C/CAdbcConnection.cs:37: unintialized ==> uninitialized
csharp/src/Apache.Arrow.Adbc/C/CAdbcDatabase.cs:39: unintialized ==> uninitialized
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriver.cs:40: unintialized ==> uninitialized
csharp/src/Apache.Arrow.Adbc/C/CAdbcDriver.cs:47: unintialized ==> uninitialized
csharp/src/Apache.Arrow.Adbc/C/CAdbcPartitions.cs:63: unintialized ==> uninitialized
csharp/src/Apache.Arrow.Adbc/C/CAdbcStatement.cs:47: unintialized ==> uninitialized
csharp/src/Client/AdbcConnection.cs:45: Intializes ==> Initializes
csharp/src/Client/AdbcConnection.cs:56: Intializes ==> Initializes
csharp/src/Drivers/Apache/Hive2/DecimalUtility.cs:172: fron ==> from, front
csharp/src/Drivers/Apache/Hive2/README.md:70: specifed ==> specified
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:140: defintion ==> definition
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:153: defintion ==> definition
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:35: defintion ==> definition
csharp/src/Drivers/Apache/Hive2/SqlTypeNameParser.cs:490: STUCT ==> STRUCT
csharp/src/Drivers/Apache/Impala/README.md:106: standar ==> standard
csharp/src/Drivers/Apache/Impala/README.md:68: specifed ==> specified
csharp/src/Drivers/Apache/Spark/README.md:64: specifed ==> specified
csharp/src/Drivers/Apache/Thrift/BitmapUtilities.cs:53: remaing ==> remaining
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:124: Ditionary ==> Dictionary
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:198: formated ==> formatted
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:214: formated ==> formatted
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:230: formated ==> formatted
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:307: statment ==> statement
csharp/test/Apache.Arrow.Adbc.Tests/TestBase.cs:62: ouput ==> output
csharp/test/Drivers/Apache/Common/ClientTests.cs:214: timout ==> timeout
csharp/test/Drivers/Apache/Common/DateTimeValueTests.cs:61: Timstamp ==> Timestamp
csharp/test/Drivers/Apache/Common/DateTimeValueTests.cs:83: Timstamp ==> Timestamp
csharp/test/Drivers/Apache/Impala/Resources/impalaconfig.json:8: schem ==> scheme
csharp/test/Drivers/Apache/Spark/SparkConnectionTest.cs:48: exeption ==> exception, exemption
csharp/test/Drivers/Apache/Spark/SparkConnectionTest.cs:49: exeption ==> exception, exemption
csharp/test/Drivers/BigQuery/AuthenticationTests.cs:65: behvior ==> behavior
csharp/test/Drivers/Databricks/DatabricksConnectionTest.cs:55: exeption ==> exception, exemption
csharp/test/Drivers/Databricks/DatabricksConnectionTest.cs:56: exeption ==> exception, exemption
csharp/test/Drivers/Databricks/DateTimeValueTests.cs:42: Timstamp ==> Timestamp
csharp/test/Drivers/Databricks/StatementTests.cs:437: mintues ==> minutes
csharp/test/Drivers/Interop/FlightSql/readme.md:36: compatibilty ==> compatibility
csharp/test/Drivers/Interop/FlightSql/readme.md:62: resutls ==> results
csharp/test/Drivers/Interop/Snowflake/SnowflakeTestingUtils.cs:169: occured ==> occurred
csharp/test/Drivers/Interop/Snowflake/SnowflakeTestingUtils.cs:169: resouce ==> resource
dev/bench/README.md:42: passsword ==> password
dev/release/verify-release-candidate.sh:950: enviroment ==> environment
docs/source/driver/flight_sql.rst:226: reponse ==> response
docs/source/driver/postgresql.rst:351: posgresql ==> postgresql
docs/source/driver/postgresql.rst:42: accellerate ==> accelerate
docs/source/driver/snowflake.rst:294: bandwith ==> bandwidth
docs/source/faq.rst:177: tranposing ==> transposing
docs/source/format/specification.rst:248: retrive ==> retrieve
docs/source/python/recipe/flight_sql.rst:22: againt ==> against
go/adbc/adbc.go:647: returnes ==> returns
go/adbc/driver/bigquery/statement.go:572: Unparseable ==> Unparsable
go/adbc/driver/flightsql/flightsql_statement.go:429: returnes ==> returns
go/adbc/driver/internal/driverbase/connection.go:372: implementor ==> implementer
go/adbc/driver/internal/driverbase/rotating_file_writer.go:260: exising ==> existing
go/adbc/driver/internal/driverbase/rotating_file_writer.go:293: lexigraphically ==> lexicographically
go/adbc/driver/snowflake/bulk_ingestion.go:491: propogate ==> propagate
go/adbc/driver/snowflake/bulk_ingestion.go:561: recieved ==> received
go/adbc/driver/snowflake/bulk_ingestion.go:88: bandwith ==> bandwidth
go/adbc/driver/snowflake/connection.go:190: hasTables ==> hashtables
go/adbc/driver/snowflake/connection.go:195: hasTables ==> hashtables
go/adbc/driver/snowflake/connection.go:204: hasTables ==> hashtables
go/adbc/driver/snowflake/driver_test.go:2075: exepected ==> expected
go/adbc/driver/snowflake/driver_test.go:2093: exepected ==> expected
go/adbc/driver/snowflake/statement.go:470: returnes ==> returns
go/adbc/drivermgr/arrow-adbc/adbc.h:305: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:862: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:885: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:923: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:962: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:990: unintialized ==> uninitialized
go/adbc/drivermgr/arrow-adbc/adbc.h:994: unintialized ==> uninitialized
go/adbc/ext.go:68: Implementors ==> Implementers
r/adbcdrivermanager/src/options.cc:106: suppported ==> supported
r/adbcdrivermanager/src/options.cc:127: suppported ==> supported
r/adbcdrivermanager/src/options.cc:84: suppported ==> supported
rust/core/src/driver_manager.rs:157: droped ==> dropped
rust/core/src/ffi/types.rs:116: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:129: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:133: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:65: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:673: transfered ==> transferred
rust/core/src/ffi/types.rs:77: unintialized ==> uninitialized
rust/core/src/ffi/types.rs:89: unintialized ==> uninitialized
rust/core/src/lib.rs:56: langages ==> languages
rust/driver/dummy/tests/driver_exporter_dummy.rs:19: trough ==> through
rust/driver/snowflake/src/duration.rs:49: eror ==> error
rust/README.md:51: trough ==> through

.codespell-ignore

daipom · 2025-05-28T07:18:47Z

I believe the current detections are true positives.

I noticed these are FPs. I added hastables.

go/adbc/driver/snowflake/connection.go:190: hasTables ==> hashtables
go/adbc/driver/snowflake/connection.go:195: hasTables ==> hashtables
go/adbc/driver/snowflake/connection.go:204: hasTables ==> hashtables

daipom · 2025-06-09T09:57:49Z

I added schem to the ignoring list.
It appears to be used intentionally.

csharp/test/Drivers/Apache/Impala/Resources/impalaconfig.json:8: schem ==> scheme

arrow-adbc/csharp/src/Drivers/Databricks/DatabricksStatement.cs

Lines 295 to 304 in 4430379

    
           new StringArray.Builder().Build(), // TABLE_CAT 
        
           new StringArray.Builder().Build(), // TABLE_SCHEM 
        
           new StringArray.Builder().Build(), // TABLE_NAME 
        
           new StringArray.Builder().Build(), // TABLE_TYPE 
        
           new StringArray.Builder().Build(), // REMARKS 
        
           new StringArray.Builder().Build(), // TYPE_CAT 
        
           new StringArray.Builder().Build(), // TYPE_SCHEM 
        
           new StringArray.Builder().Build(), // TYPE_NAME 
        
           new StringArray.Builder().Build(), // SELF_REFERENCING_COL_NAME 
        
           new StringArray.Builder().Build()  // REF_GENERATION

daipom · 2025-06-16T08:43:37Z

#2863 (comment)

Skipped go/adbc/go.sum.

daipom · 2025-06-19T08:31:02Z

I added .codespell-ignore to rat_exclude_files.txt since we can't add the License header to .codespell-ignore.

codespell --help

-I FILES, --ignore-words FILES
comma-separated list of files that contain words to be ignored by codespell. Files must contain 1 word per line. Words are case sensitive based on how they are written in the dictionary file.

Also, I checked the code of codespell.
It appears that it simply regards each line as a word to be ignored.

daipom · 2025-06-19T08:38:03Z

Update https://github.com/apache/arrow-adbc/blob/fd850006a5720fb778e49fbc89e34e9491994654/CONTRIBUTING.md#opening-a-pull-request

daipom · 2025-06-19T08:41:29Z

Finally, it's ready!

kou

+1

kou · 2025-06-19T08:45:58Z

Is this a typo...?

csharp/test/Drivers/Apache/Impala/Resources/impalaconfig.json:8: schem ==> scheme

daipom · 2025-06-19T08:48:08Z

Is this a typo...?

csharp/test/Drivers/Apache/Impala/Resources/impalaconfig.json:8: schem ==> scheme

I believe this is not a typo.
I investigated this word, and it appears to be a common term.

daipom · 2025-06-19T08:52:05Z

https://learn.microsoft.com/en-us/sql/connect/jdbc/reference/gettables-method-sqlserverdatabasemetadata?view=sql-server-ver17#remarks

TABLE_SCHEM

kou · 2025-06-19T08:52:06Z

arrow-adbc/csharp/test/Drivers/Apache/Impala/Resources/impalaconfig.json

Line 8 in fd85000

"schema": "<schem>",

It seems that it's appeared as a value of the schema key...

daipom · 2025-06-19T09:00:07Z

I see...
Since the terms "TABLE_SCHEM" and "TYPE_SCHEM" are official, I thought "schem" would be acceptable.
But, indeed, it might actually just be a typo for "schema"...

daipom · 2025-06-19T09:02:00Z

Thanks! I will remove schem from the ignore-list, and fix the following!

arrow-adbc/csharp/test/Drivers/Apache/Impala/Resources/impalaconfig.json

Line 8 in fd85000

"schema": "<schem>",

daipom · 2025-06-20T02:30:10Z

Ready!

lidavidm

Thank you!

daipom · 2025-06-20T09:27:19Z

Welcome!

kou reviewed May 27, 2025

View reviewed changes

.pre-commit-config.yaml Outdated Show resolved Hide resolved

daipom force-pushed the pre-commit-add-codespell branch from 70f2bea to 5d19f78 Compare May 28, 2025 06:16

This was referenced May 28, 2025

pre-commit: add a spell checker like codespell #2863

Closed

docs: fix typo #2887

Closed

lidavidm reviewed May 28, 2025

View reviewed changes

.codespell-ignore Outdated Show resolved Hide resolved

daipom force-pushed the pre-commit-add-codespell branch 3 times, most recently from 6a5de3c to 9bca6bb Compare May 28, 2025 07:16

daipom mentioned this pull request Jun 5, 2025

c: fix typo #2923

Closed

daipom force-pushed the pre-commit-add-codespell branch from 9bca6bb to 70c9132 Compare June 5, 2025 15:13

daipom mentioned this pull request Jun 6, 2025

go: fix typo #2927

Closed

daipom force-pushed the pre-commit-add-codespell branch 2 times, most recently from 5cb09b3 to 995b641 Compare June 9, 2025 09:52

daipom mentioned this pull request Jun 9, 2025

csharp: fix typo #2932

Closed

daipom force-pushed the pre-commit-add-codespell branch 2 times, most recently from be80b20 to 74199a5 Compare June 10, 2025 00:10

daipom mentioned this pull request Jun 10, 2025

csharp: fix typo #2945

Closed

daipom force-pushed the pre-commit-add-codespell branch from 74199a5 to e064a01 Compare June 11, 2025 00:48

daipom mentioned this pull request Jun 11, 2025

rust: fix typo #2954

Closed

daipom force-pushed the pre-commit-add-codespell branch 3 times, most recently from 3642fa3 to 09c1948 Compare June 16, 2025 08:42

This was referenced Jun 16, 2025

chore: fix typo in CHANGELOG #2972

Closed

chore(r): fix typo #2974

Closed

daipom force-pushed the pre-commit-add-codespell branch 3 times, most recently from ec7fe48 to 16d2c5e Compare June 19, 2025 08:21

daipom force-pushed the pre-commit-add-codespell branch from 16d2c5e to cf06a22 Compare June 19, 2025 08:36

daipom marked this pull request as ready for review June 19, 2025 08:40

github-actions bot added this to the ADBC Libraries 19 milestone Jun 19, 2025

kou approved these changes Jun 19, 2025

View reviewed changes

daipom marked this pull request as draft June 19, 2025 09:02

daipom force-pushed the pre-commit-add-codespell branch from cf06a22 to 679ae72 Compare June 19, 2025 09:08

daipom mentioned this pull request Jun 19, 2025

csharp: fix typo #3001

Closed

chore: add codespell

94707f3

daipom force-pushed the pre-commit-add-codespell branch from 679ae72 to 94707f3 Compare June 20, 2025 02:19

daipom marked this pull request as ready for review June 20, 2025 02:29

lidavidm approved these changes Jun 20, 2025

View reviewed changes

lidavidm merged commit 7190e0b into apache:main Jun 21, 2025
4 checks passed

daipom deleted the pre-commit-add-codespell branch June 23, 2025 02:01

serramatutu mentioned this pull request Aug 12, 2025

Sync upstream dbt-labs/arrow-adbc#52

Closed

chore: add codespell #2864

chore: add codespell #2864

Uh oh!

Conversation

daipom commented May 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daipom commented May 26, 2025

Uh oh!

daipom commented May 26, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

daipom commented May 28, 2025

Uh oh!

kou commented May 28, 2025

Uh oh!

daipom commented May 28, 2025

Uh oh!

Uh oh!

daipom commented May 28, 2025

Uh oh!

daipom commented Jun 9, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daipom commented Jun 16, 2025

Uh oh!

daipom commented Jun 19, 2025

Uh oh!

daipom commented Jun 19, 2025

Uh oh!

daipom commented Jun 19, 2025

Uh oh!

kou left a comment

Choose a reason for hiding this comment

Uh oh!

kou commented Jun 19, 2025

Uh oh!

daipom commented Jun 19, 2025

Uh oh!

daipom commented Jun 19, 2025

Uh oh!

kou commented Jun 19, 2025

Uh oh!

daipom commented Jun 19, 2025

Uh oh!

daipom commented Jun 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

daipom commented Jun 20, 2025

Uh oh!

lidavidm left a comment

Choose a reason for hiding this comment

Uh oh!

daipom commented Jun 20, 2025

Uh oh!

Uh oh!

Uh oh!

daipom commented May 26, 2025 •

edited

Loading

daipom commented Jun 9, 2025 •

edited

Loading

daipom commented Jun 19, 2025 •

edited

Loading