feat(c/driver/postgresql): Implement GetParameterSchema for statement #2881
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
May 27, 2025
This (slightly hackily) works around an issue that the underlying driver seems to convert Python ints in bound parameters to BIGINT, which makes it difficult to use them in arguments to functions that only have INT versions, and these functions are used in SQLAlchemy's reflection system. When apache/arrow-adbc#2881 is merged/deployed, hopefully we can remove the work around.
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
May 27, 2025
This (slightly hackily) works around an issue that the underlying driver seems to convert Python ints in bound parameters to BIGINT, which makes it difficult to use them in arguments to functions that only have INT versions, and these functions are used in SQLAlchemy's reflection system. When apache/arrow-adbc#2881 is merged/deployed, hopefully we can remove the work around.
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
May 27, 2025
This (slightly hackily) works around an issue that the underlying driver seems to convert Python ints in bound parameters to BIGINT, which makes it difficult to use them in arguments to functions that only have INT versions, and these functions are used in SQLAlchemy's reflection system. When apache/arrow-adbc#2881 is merged/deployed, hopefully we can remove the work around. This includes a bump of the minimum SQLAlchemy version on Python 3.13 to fix the error when traversing: AttributeError: 'functools._lru_cache_wrapper' object has no attribute '_annotations'. Did you mean: '__annotations__
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
May 27, 2025
This (slightly hackily) works around an issue that the underlying driver seems to convert Python ints in bound parameters to BIGINT, which makes it difficult to use them in arguments to functions that only have INT versions, and these functions are used in SQLAlchemy's reflection system. When apache/arrow-adbc#2881 is merged/deployed, hopefully we can remove the work around. This includes a bump of the minimum SQLAlchemy version on Python 3.13 to fix the error when traversing: AttributeError: 'functools._lru_cache_wrapper' object has no attribute '_annotations'. Did you mean: '__annotations__'?
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
May 27, 2025
This (slightly hackily) works around an issue that the underlying driver seems to convert Python ints in bound parameters to BIGINT, which makes it difficult to use them in arguments to functions that only have INT versions, and these functions are used in SQLAlchemy's reflection system. When apache/arrow-adbc#2881 is merged/deployed, hopefully we can remove the work around. This includes a bump of the minimum SQLAlchemy version on Python 3.13 to fix the error when traversing: AttributeError: 'functools._lru_cache_wrapper' object has no attribute '_annotations'. Did you mean: '__annotations__'?
michalc
added a commit
to michalc/pgarrow
that referenced
this pull request
May 27, 2025
This (slightly hackily) works around an issue that the underlying driver seems to convert Python ints in bound parameters to BIGINT, which makes it difficult to use them in arguments to functions that only have INT versions, and these functions are used in SQLAlchemy's reflection system. When apache/arrow-adbc#2881 is merged/deployed, hopefully we can remove the work around. This includes a bump of the minimum SQLAlchemy version on Python 3.13 to fix the error when traversing: AttributeError: 'functools._lru_cache_wrapper' object has no attribute '_annotations'. Did you mean: '__annotations__'?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...turns out I implemented the helper but never wired it up 🤦
Closes #2880 (when tested)