Skip to content

Match parameter order on sourceURL method to binaryURL #367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jamesfredley
Copy link
Contributor

@jamesfredley jamesfredley commented Jun 18, 2025

Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR updates the parameter order of the sourceUrl method to match that of the binaryUrl method for consistency.

  • Reorders parameters in the sourceUrl method signature from (version, ext, artifact, directory) to (version, artifact, ext, directory).
  • Updates all call sites to sourceUrl to reflect the new parameter order.
Comments suppressed due to low confidence (2)

buildSrc/src/main/groovy/org/grails/documentation/DownloadPage.groovy:33

  • The reordered parameters in sourceUrl now match the binaryUrl parameter order, improving API consistency; ensure any related documentation and tests are updated accordingly.
    static String sourceUrl(String version, String artifact='grails', String ext = '', String directory = 'core') {

buildSrc/src/main/groovy/org/grails/documentation/DownloadPage.groovy:53

  • The call site now matches the new parameter ordering; please verify that all invocations are updated consistently across the file.
                            a(href: sourceUrl(version, 'grails', '.sha512'), 'SHA512')

@jamesfredley jamesfredley self-assigned this Jun 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

2 participants