OAK-9586: SysViewImportHandler does not support expanded names in sv:name attributes #2223
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…name attributes Prelimary fix, needs beautification.
Commit-Check ✔️ |
mbaedke
commented
Apr 10, 2025
| } catch (NamespaceException expected) { | ||
| // this is an expanded svName using an unregistered namespace | ||
| // we need to make up a prefix for the namespace | ||
| prefix = "ns_" + UUID.randomUUID().toString().substring(0, 8); |
There was a problem hiding this comment.
That's temporary. We already have other places where we create ns prefixes, I'm going to clone from there.
…name attributes Test cases.
…name attributes Added comment.
…name attributes Renamed private method.
|
kwin
requested changes
May 7, 2025
| return "ns_" + UUID.randomUUID().toString().substring(0, 8); | ||
| } | ||
|
|
||
| private NameInfo createNameInfo(String svName) throws RepositoryException { |
There was a problem hiding this comment.
I think this whole logic should be common across all JCR methods potentially creating new items (with potentially unregistered expanded names) such as
Node.addNode(...)Node.setProperty(...)Session.move(...)
Probably one needs to add a SessionContext.getOrCreateOakPath(...) similar to the getOakPath(...) which is called from all those methods. The implementation should delegate to a new method PathMapper.getOrCreateOakPath(...) which should automatically register all unknown prefixes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prefix generation is preliminary.