fix: Duplicate deferred fragment identifiers #700
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for apollo-ios-docc canceled.
|
✅ Docs preview has no changesThe preview was not built because there were no changes. Build ID: 04f9eb3a3d720a23f3df0d32 |
calvincestari
commented
Jul 3, 2025
| /// fragment identifier which is shared amongst all child selection set types within a deferred fragment. | ||
| /// | ||
| /// - Returns: Hash value of `path` and `deferCondition`. | ||
| var pathDeferConditionHash: Int { |
There was a problem hiding this comment.
The alternative to this and the unique(by:) extension on Sequence was to make DeferredPathTypeInfo conform to Hashable but manipulate the hashing and equality functions to exclude typeName. That felt like a step too far removed from what I was trying to do, so I settled on this specific implementation instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apollographql/apollo-ios#3565.
The deferred fragment identifier was being generated using all elements in the deferred fragments path type info array. While the contents of that array are correct because of the unique selection sets, the identifier is able to be shared amongst elements with the same path and defer condition. Taking this into account the identifiers are now generated without duplicates.