Skip to content

[PM-20554] fix admin endpoint for deleting unassigned items #6061

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

BTreston
Copy link
Contributor

@BTreston BTreston commented Jul 8, 2025

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-20554

📔 Objective

This PR fixes an issue where you are unable to delete or restore unassigned items.

📸 Screenshots

Screen.Recording.2025-07-08.at.1.32.15.PM.mov

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

@BTreston BTreston requested a review from a team as a code owner July 8, 2025 17:37
@BTreston BTreston requested a review from gbubemismith July 8, 2025 17:37
Copy link
Contributor

github-actions bot commented Jul 8, 2025

Logo
Checkmarx One – Scan Summary & Details1c7a01b0-f3d9-4ffb-9530-93fe5d2e6f97

Great job, no security vulnerabilities found in this Pull Request

@BTreston BTreston changed the title [PM-20555] fix admin endpoint for deleting unassigned items [PM-20554] fix admin endpoint for deleting unassigned items Jul 8, 2025
Copy link

codecov bot commented Jul 8, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 48.06%. Comparing base (37cdefb) to head (7bd230a).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
src/Api/Vault/Controllers/CiphersController.cs 25.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6061      +/-   ##
==========================================
- Coverage   51.35%   48.06%   -3.29%     
==========================================
  Files        1703     1730      +27     
  Lines       75567    76305     +738     
  Branches     6799     6844      +45     
==========================================
- Hits        38805    36678    -2127     
- Misses      35234    38138    +2904     
+ Partials     1528     1489      -39     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@BTreston BTreston requested a review from gbubemismith July 11, 2025 17:26
gbubemismith
gbubemismith previously approved these changes Jul 11, 2025
@gbubemismith gbubemismith self-requested a review July 11, 2025 17:32
@gbubemismith
Copy link
Contributor

Looks like the tests are failing

Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants