Flatten CI workflow & remove unnecessary CI caching #36
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stig
force-pushed
the
remove-useless-caching
branch
from
36d8408 to
d31736e
Compare
conormcd
reviewed
Mar 22, 2024
stig
force-pushed
the
remove-useless-caching
branch
from
d31736e to
07e597c
Compare
The CI cache is tied to as single branch, and is not very effective. It is my estimation that we don't build this often enough that the caching is worth the extra complexity in the config. Flatten the workflow so the tests don't have to depend on the check. This means fewer CI roundtrips to find out that both check and test jobs fail.
stig
force-pushed
the
remove-useless-caching
branch
from
07e597c to
a77cf21
Compare
calvis
approved these changes
Mar 22, 2024
gordonsyme
reviewed
Mar 22, 2024
| - run: lein deps | ||
|
|
||
| - run: lein check |
There was a problem hiding this comment.
What do you think about running lein check in the test job? Save a container.
There was a problem hiding this comment.
Yeah, that seems sensible. I had already merged, so made a new PR: #38
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The CI cache is tied to as single branch, and is not very effective. It is my estimation that we don't build this often enough that the caching is worth the extra complexity in the config.
Flatten the workflow so the tests don't have to depend on the check. This means fewer CI roundtrips to find out that both check and test jobs fail.