Automate publishing of tagged releases to Clojars #37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
calvis
approved these changes
Mar 22, 2024
stig
changed the title
stig
force-pushed
the
deploy
branch
4 times, most recently
from
c429574 to
985b3ae
Compare
calvis
reviewed
Mar 22, 2024
So that we don't need to find credentials and remember how to release changes manually. Git tags are used to trigger publishing so that we don't re-publish over existing versions every time we merge to master. It also means that we're more likely to remember to tag and don't need to add any logic or credentials for the workflow to create tags. An alternative would have been to use the build number as a patch version, but it's unwieldy for both for users and for us to maintain the versions in `README.md` and `CHANGELOG.md`. The `CLOJARS_USERNAME` and `CLOJARS_TOKEN` environment variables come from a context. The project already has "build forks" and "pass secrets to fork builds" disabled, which will prevent leaking these credentials.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
So that we don't need to find credentials and remember how to release changes manually. Git tags are used to trigger publishing so that we don't re-publish over existing versions every time we merge to master. It also means that we're more likely to remember to tag and don't need to add any logic or credentials for the workflow to create tags.
An alternative would have been to use the build number as a patch version, but it's unwieldy for both for users and for us to maintain the versions in
README.mdandCHANGELOG.md.I cribbed liberally from circleci/bond#52 for this.
Once this is merged I intend to use it to address #18 and #16