Skip to content

Rmenziejr/feat async geval 2 #2531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Rmenziejr/feat async geval 2 #2531

wants to merge 3 commits into from

Conversation

rmenziejr
Copy link

@rmenziejr rmenziejr commented Jun 20, 2025

Details

  • created new method for chain of thought to be async method then swapped that with the sync method in ascore.
  • removed reliance on functools cachedproperty due to incompatability with async processes
  • created a 'self-managed' cache for both chain of thought methods to store first-run results for reuse

Issues

Resolves #2497

Testing

completed internal testing succesfully no unit tests applicable

Documentation

No change in docs needed

* add asyncstdlib package

* [MISC] update geval with async COT method

* created new method for chain of thought to be async method then swapped that with the sync method in ascore
@rmenziejr rmenziejr requested a review from a team as a code owner June 20, 2025 12:21
* [MISC] update geval with async COT method

* created new method for chain of thought to be async method then swapped that with the sync method in ascore
@yaricom
Copy link
Member

yaricom commented Jun 30, 2025

@rmenziejr Hi!

Thank you for your work on this. We’d prefer not to introduce new dependencies like asyncstdlib into the codebase. Ideally, we should avoid using the @a.cached_property and @cached_property decorators. Instead, let’s store the estimated CoT value in a class field. This approach will allow us to implement caching while keeping the allm_chain_of_thought method asynchronous.

With kind regards,
Iaroslav

@rmenziejr
Copy link
Author

Hi @yaricom ! This works for me. I was attempting to replicate the current process as much as possible which required the new packaging, but if we want to refactor the caching process to be a class field instead i can make that update and resubmit!

Thanks for the feedback

@andrescrz
Copy link
Collaborator

@rmenziejr

Thank you for your work on this PR! When you have a chance, could you please address the requested changes and submit a new revision? We’ll be happy to review it again once the updates are in. If you have any questions or need clarification, feel free to ask!

@rmenziejr
Copy link
Author

Yes I have it on my calendar to tackle this week just been on holiday. Should see something come across today or tomorrow likely

@rmenziejr
Copy link
Author

@andrescrz

Hi Andres, new revision is complete. updated the original PR Request to reflect new changes based on feedback.

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

llm chain of thought in ascore attempts to run a synchronous call to Async Client
3 participants