[WIP]: build tags #4400
[WIP]: build tags #4400
Conversation
| vendor/github.com/containerd/nydus-snapshotter \ | ||
| vendor/github.com/containerd/stargz-snapshotter \ | ||
| vendor/github.com/containerd/accelerated-container-image | ||
| BUILDTAGS=no_ipfs,no_nydus,no_esgz,no_obd make binaries |
There was a problem hiding this comment.
Tags should be named no_${SNAPSHOTTER_NAME}
| BUILDTAGS=no_ipfs,no_nydus,no_esgz,no_obd make binaries | |
| BUILDTAGS=no_ipfs,no_nydus,no_stargz,no_overlaybd make binaries |
There was a problem hiding this comment.
esgz -> stargz - I was wondering - we might want to do that generally (eg: on var and func names as well).
There was a problem hiding this comment.
Maybe yes, but it can be discussed separately, as var names and func names are not visible to users and package maintainers.
| go mod vendor | ||
| rm -rf vendor/github.com/ipfs vendor/github.com/multiformats | ||
| BUILDTAGS=no_ipfs make binaries |
There was a problem hiding this comment.
This one should be still tested
There was a problem hiding this comment.
They all are tested below, right?
There was a problem hiding this comment.
No, we should still make sure that compilation of no_ipfs doesn't need explicitly specifying no_stargz, and vice versa.
There was a problem hiding this comment.
I see what you mean.
I'll separate them.
|
Thanks @AkihiroSuda for the early feedback. I will try to get that done tonight before I fly to EU for vacation tomorrow. |
TBD