-
Notifications
You must be signed in to change notification settings - Fork 85
all(breaking): Fix typoes and add spell checking workflow #381
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
breaking changes: - `Throttling` struct field name `throtted_periods` -> `throttled_periods` - `Throttling` struct field name `throtted_time` -> `throttled_time` - `SimpleWriteVistor` -> `SimpleWriteVisitor` This commit also adds a spell checking workflow to the repository. Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com> Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@Mossaka this should be good to merge. Could you pls take a look on merge conflicts? |
This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed. |
This PR was closed because it has been stalled for 7 days with no activity. |
breaking changes:
Throttling
struct field namethrotted_periods
->throttled_periods
Throttling
struct field namethrotted_time
->throttled_time
SimpleWriteVistor
->SimpleWriteVisitor
This commit also adds a spell checking workflow to the repository.