Skip to content

all(breaking): Fix typoes and add spell checking workflow #381

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

Mossaka
Copy link
Member

@Mossaka Mossaka commented Mar 5, 2025

breaking changes:

  • Throttling struct field name throtted_periods -> throttled_periods
  • Throttling struct field name throtted_time -> throttled_time
  • SimpleWriteVistor -> SimpleWriteVisitor

This commit also adds a spell checking workflow to the repository.

breaking changes:
- `Throttling` struct field name `throtted_periods` -> `throttled_periods`
- `Throttling` struct field name `throtted_time` -> `throttled_time`
- `SimpleWriteVistor` -> `SimpleWriteVisitor`

This commit also adds a spell checking workflow to the repository.

Signed-off-by: Jiaxiao (mossaka) Zhou <duibao55328@gmail.com>
@github-actions github-actions bot added T-docs Improvements or additions to documentation C-runc-shim Runc shim C-shim Containerd shim C-snapshots Remote snapshotter C-runc runc helper T-CI Changes in project's CI labels Mar 5, 2025
@Mossaka Mossaka changed the title all: Fix typoes and add spell checking workflow all(breaking): Fix typoes and add spell checking workflow Mar 5, 2025
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Jorge Prendes <jorge.prendes@gmail.com>
Signed-off-by: Jiaxiao Zhou <duibao55328@gmail.com>
Copy link
Contributor

@jprendes jprendes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mxpv mxpv added this pull request to the merge queue Mar 12, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 12, 2025
@mxpv mxpv added this pull request to the merge queue Mar 14, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 14, 2025
@mxpv mxpv added this pull request to the merge queue Mar 19, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Mar 19, 2025
@mxpv
Copy link
Member

mxpv commented Mar 19, 2025

@Mossaka this should be good to merge. Could you pls take a look on merge conflicts?

Copy link

This PR is stale because it has been open 90 days with no activity. This PR will be closed in 7 days unless new comments are made or the stale label is removed.

@github-actions github-actions bot added the Stale label Jun 30, 2025
Copy link

github-actions bot commented Jul 7, 2025

This PR was closed because it has been stalled for 7 days with no activity.

@github-actions github-actions bot closed this Jul 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-runc runc helper C-runc-shim Runc shim C-shim Containerd shim C-snapshots Remote snapshotter needs update Stale T-CI Changes in project's CI T-docs Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants