Skip to content

Commit 678f54f

Browse files
committed
add conditional to fetch the right token
1 parent 6a59a67 commit 678f54f

File tree

4 files changed

+16
-7
lines changed

4 files changed

+16
-7
lines changed

cli/pkg/spec/manual.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ func RunSpecManualCommand(
102102
cmd.Stderr = os.Stderr
103103
cmd.Run()
104104

105-
policyChecker, err := policyProvider.GetPolicyProvider(spec.Policy, spec.Backend.BackendHostname, spec.Backend.BackendOrganisationName, spec.Backend.BackendJobToken)
105+
policyChecker, err := policyProvider.GetPolicyProvider(spec.Policy, spec.Backend.BackendHostname, spec.Backend.BackendOrganisationName, spec.Backend.BackendJobToken, spec.VCS.VcsType)
106106
if err != nil {
107107
usage.ReportErrorAndExit(spec.VCS.Actor, fmt.Sprintf("could not get policy provider: %v", err), 1)
108108
}

cli/pkg/spec/spec.go

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -105,7 +105,7 @@ func RunSpec(
105105
reportError(spec, backendApi, message, err)
106106
}
107107

108-
policyChecker, err := policyProvider.GetPolicyProvider(spec.Policy, spec.Backend.BackendHostname, spec.Backend.BackendOrganisationName, spec.Backend.BackendJobToken)
108+
policyChecker, err := policyProvider.GetPolicyProvider(spec.Policy, spec.Backend.BackendHostname, spec.Backend.BackendOrganisationName, spec.Backend.BackendJobToken, spec.VCS.VcsType)
109109
if err != nil {
110110
message := fmt.Sprintf("could not get policy provider: %v", err)
111111
reportError(spec, backendApi, message, err)

ee/cli/pkg/policy/providers.go

Lines changed: 12 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -10,11 +10,20 @@ import (
1010

1111
type AdvancedPolicyProvider struct{}
1212

13-
func (p AdvancedPolicyProvider) GetPolicyProvider(policySpec lib_spec.PolicySpec, diggerHost string, diggerOrg string, token string) (policy.Checker, error) {
13+
func (p AdvancedPolicyProvider) GetPolicyProvider(policySpec lib_spec.PolicySpec, diggerHost string, diggerOrg string, token string, vcsType string) (policy.Checker, error) {
1414
managementRepo := os.Getenv("DIGGER_MANAGEMENT_REPO")
1515
if managementRepo != "" {
1616
log.Printf("info: using management repo policy provider")
17-
token := os.Getenv("GITLAB_TOKEN")
17+
var token = ""
18+
switch vcsType {
19+
case "github":
20+
token = os.Getenv("GITHUB_TOKEN")
21+
case "gitlab":
22+
token = os.Getenv("GITLAB_TOKEN")
23+
default:
24+
token = os.Getenv("GITHUB_TOKEN")
25+
}
26+
1827
if token == "" {
1928
return nil, fmt.Errorf("failed to get managent repo policy provider: GITHUB_TOKEN not specified")
2029
}
@@ -26,7 +35,7 @@ func (p AdvancedPolicyProvider) GetPolicyProvider(policySpec lib_spec.PolicySpec
2635
}, nil
2736
}
2837

29-
checker, err := lib_spec.BasicPolicyProvider{}.GetPolicyProvider(policySpec, diggerHost, diggerOrg, token)
38+
checker, err := lib_spec.BasicPolicyProvider{}.GetPolicyProvider(policySpec, diggerHost, diggerOrg, token, "")
3039
return checker, err
3140
}
3241

libs/spec/providers.go

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -315,12 +315,12 @@ func (v VCSProviderBasic) GetOrgService(vcsSpec VcsSpec) (ci.OrgService, error)
315315
}
316316

317317
type SpecPolicyProvider interface {
318-
GetPolicyProvider(policySpec PolicySpec, diggerHost string, diggerOrg string, token string) (policy2.Checker, error)
318+
GetPolicyProvider(policySpec PolicySpec, diggerHost string, diggerOrg string, token string, vcsType string) (policy2.Checker, error)
319319
}
320320

321321
type BasicPolicyProvider struct{}
322322

323-
func (p BasicPolicyProvider) GetPolicyProvider(policySpec PolicySpec, diggerHost string, diggerOrg string, token string) (policy2.Checker, error) {
323+
func (p BasicPolicyProvider) GetPolicyProvider(policySpec PolicySpec, diggerHost string, diggerOrg string, token string, vcsType string) (policy2.Checker, error) {
324324
slog.Debug("Getting policy provider",
325325
"policyType", policySpec.PolicyType,
326326
"diggerHost", diggerHost,

0 commit comments

Comments
 (0)