Skip to content

dangling lock when PR revert commit #1990

Open
@motatoes

Description

@motatoes

Reproduction scenario:

  • First PR created, touching two projects say “eks”,
  • A commit added to PR touching another project say “vpc”
  • a revert pushed to first PR which undo the changes to “eks”, now the PR only touches “vpc” project
  • second PR created touching project “eks”
  • digger will complain that eks looked by PR Create README.md #1
  • But the digger unlock on the first PR does not unlock because this lock is now dangling (since digger looks at PR - changed files it does not attempt to unlock that PR)

In order to fix we might need to

  • Check if the PR with reverted commit still has that project as impacted and if not delete the dangling lock

Current workaround: close PR with dangling lock and then plan on the other plan, after that you can re-open the dangling lock PR since the lock would have been deleted

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions