-
Notifications
You must be signed in to change notification settings - Fork 559
fix e2e tests #1985
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix e2e tests #1985
Conversation
Caution Review failedThe pull request is closed. WalkthroughThe updates include a change to the AWS S3 bucket environment variable in a GitHub Actions workflow and a modification to error handling in the DynamoDB table creation logic. The workflow now uses a different S3 bucket for end-to-end tests, and the DynamoDB logic proceeds to table creation even if non-"table not found" errors occur during the describe operation. Changes
Poem
📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (2)
✨ Finishing Touches
🧪 Generate Unit Tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
PR Summary
Changes to improve E2E test reliability by modifying DynamoDB table creation and S3 bucket configuration.
- Modified error handling in
libs/locking/aws/dynamo_locking.go
to continue with table creation on non-TableNotFoundException errors, requiring careful monitoring - Changed S3 bucket name from 'digger-tests-bucket' to 'digger-tests-bucket-e2e' in
.github/workflows/cli_test_e2e.yml
for better resource isolation
2 files reviewed, no comments
Edit PR Review Bot Settings | Greptile
Summary by CodeRabbit
Chores
Bug Fixes