Skip to content

refactor: add missing 'new' and exception handling #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 7, 2025

Conversation

k-kbk
Copy link
Contributor

@k-kbk k-kbk commented Apr 1, 2025

  • Synchronization methods such as fs.rmSync(...) that throw an exception on failure are recommended to be wrapped in try/catch.
  • Using new to create an object is the standard and safe way to do it.

Signed-off-by: Bokyeom <79684339+k-kbk@users.noreply.github.com>
@k-kbk k-kbk force-pushed the add-exception-handling branch 2 times, most recently from 1dbd05b to eff94d9 Compare April 1, 2025 14:27
Signed-off-by: k-kbk <kkbk0077@gmail.com>
@k-kbk k-kbk force-pushed the add-exception-handling branch 2 times, most recently from 9749bec to e54c2c0 Compare April 2, 2025 11:54
crazy-max
crazy-max previously approved these changes Apr 7, 2025
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@crazy-max crazy-max dismissed their stale review April 7, 2025 12:30

remove last commit

Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the last empty commit please? Otherwise LGTM

@crazy-max crazy-max self-assigned this Apr 7, 2025
@k-kbk k-kbk force-pushed the add-exception-handling branch from e54c2c0 to 8ea72f7 Compare April 7, 2025 12:33
@k-kbk
Copy link
Contributor Author

k-kbk commented Apr 7, 2025

@crazy-max Sure! I deleted it.

@k-kbk k-kbk requested a review from crazy-max April 7, 2025 12:35
Copy link
Member

@crazy-max crazy-max left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@crazy-max crazy-max merged commit 66147ca into docker:master Apr 7, 2025
128 of 129 checks passed
@k-kbk k-kbk deleted the add-exception-handling branch April 7, 2025 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants