iOS Text Input suggestions no longer send as if they were commited #52458
Conversation
|
Hi @AdamChlupacek! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
facebook-github-bot
added
the
CLA Signed
|
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
facebook-github-bot
added
the
Shared with Meta
|
Jumping back a bit, do we no what call in this case invokes It would be great if we could ignore these updates, with provisional text entirely, instead of trying to work around them everywhere. |
| } else { | ||
| return RCTIsAttributedStringEffectivelySame( | ||
| newText, oldText, _originalTypingAttributes, static_cast<const TextInputProps &>(*_props).textAttributes); | ||
| newText, _backedTextInputView.attributedText, _originalTypingAttributes, static_cast<const TextInputProps &>(*_props).textAttributes); |
There was a problem hiding this comment.
Why are we sometimes comparing to the full string, vs string without marker?
|
Thank you for the review. I think you are right, I will have a look if there is any way we could ignore the updates. In my testing I noticed that the on change can be fired multiple times in succession with the same value, which would be nice if we could avoid. I will have another pass at this trying to get as close to the source of the event as possible. |
Summary:
This pull requests fixes behaviour of TextInput where it was setting the suggested text as if it were typed by a user. Fixes #52453
Changelog:
[IOS] [FIXED] - Fix TextInput
onChangeincludes suggested text.Test Plan:
Following snack: https://snack.expo.dev/@adchlupacek/ios-suggested-text-gets-sends-as-input
Will only output the actually typed text, not suggested.