Skip to content

Add multi-user HTTP mode: per-request GitHub token, docs, and tests #489

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add multi-user HTTP mode: per-request GitHub token, docs, and tests #489

wants to merge 2 commits into from
+455 −1

Conversation

thomcost
Copy link

@thomcost thomcost commented Jun 7, 2025 

 - Added multi-user HTTP mode with per-request GitHub token via Authorization header.
 - Updated documentation and added unit/e2e tests.
 - All tests passing.

Closes: Issue #471

@thomcost thomcost requested a review from a team as a code owner June 7, 2025 07:46
@thomcost
Optimize multi-user HTTP mode performance and security
4b15b53 
- Replace per-request MCP server creation with token-aware client factories
- Add proper HTTP timeouts and graceful shutdown
- Enhance token validation with strict Bearer format checking
- Add comprehensive tests for token extraction and context injection
- Improve error handling and response formatting
- Update documentation to reflect performance optimizations
@SamMorrowDrums
Copy link
Collaborator

Hi thank you for your contribution, we will be releasing a remote server soon, using this repo as a library. We won't be merging PRs adding this functionality for the foreseeable future.

@thomcost
Copy link
Author

thomcost commented Jun 8, 2025

Hi thank you for your contribution, we will be releasing a remote server soon, using this repo as a library. We won't be merging PRs adding this functionality for the foreseeable future.

Who is "we"?

@SamMorrowDrums
Copy link
Collaborator

GitHub, I am an internal maintainer.

@tcostello-godaddy
Copy link

Hi thank you for your contribution, we will be releasing a remote server soon, using this repo as a library. We won't be merging PRs adding this functionality for the foreseeable future.

Do you have any ballpark dates? please :)

@SamMorrowDrums
Copy link
Collaborator

I cannot be exact, but its fairly imminent.

@tonytrg
Copy link
Contributor

tonytrg commented Jun 16, 2025

@tcostello-godaddy remote mcp is live :) https://github.com/github/github-mcp-server?tab=readme-ov-file#remote-github-mcp-server

@thomcost thank you for the contribution, since we offer remote mcp now, as @SamMorrowDrums mentioned for now this will not be added to the local version.
Still the contribution is really appreciated, cheers!

@SamMorrowDrums
Copy link
Collaborator

Update: we may reconsider to unblock GHES use-cases.

@tonytrg
Copy link
Contributor

tonytrg commented Jun 17, 2025

related to #523

@ransonjb
Copy link

Update: we may reconsider to unblock GHES use-cases.

Hey @SamMorrowDrums
I would add a "+1": we are working on an important project where support for GHES is required.
Would you have an ETA for this support?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@thomcost @SamMorrowDrums @tcostello-godaddy @tonytrg @ransonjb