-
-
Notifications
You must be signed in to change notification settings - Fork 5.9k
Test latest versions of postgres,mysql,mssql in db tests #34953
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
I think it only costs unnecessary CI resources. Database should have 100% compatibility. And old database version passes, the new ones should pass. |
Didn't we have one issue rather recently where something was failing on a recent postgres version? I think it was very recent, like in the last 6 months. |
I think #31205 was the last such issue. |
I don't see so. Most pgsql related failures are related to the |
Combined, this will a 1 hour of CI time to every backend-related pull request. Up for the admins to decide whether this is worth it. |
I don't think it is related to version. The reporter just happened to be running pgsql 16 |
I'm fine with whatever decision we make on this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, I don't think we need to do this. The CI is already pretty slow
Test both the minimum and latest versions of these databases. This will increase CI load for db-related pull requests.