Skip to content

Test latest versions of postgres,mysql,mssql in db tests #34953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

silverwind
Copy link
Member

Test both the minimum and latest versions of these databases. This will increase CI load for db-related pull requests.

@GiteaBot GiteaBot added the lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. label Jul 4, 2025
@wxiaoguang
Copy link
Contributor

I think it only costs unnecessary CI resources.

Database should have 100% compatibility. And old database version passes, the new ones should pass.

@silverwind
Copy link
Member Author

silverwind commented Jul 4, 2025

Didn't we have one issue rather recently where something was failing on a recent postgres version? I think it was very recent, like in the last 6 months.

@silverwind
Copy link
Member Author

I think #31205 was the last such issue.

@wxiaoguang
Copy link
Contributor

Didn't we have one issue rather recently where something was failing on a recent postgres version? I think it was very recent, like in the last 6 months.

I don't see so. Most pgsql related failures are related to the user table vs keyword.

@silverwind
Copy link
Member Author

Combined, this will a 1 hour of CI time to every backend-related pull request. Up for the admins to decide whether this is worth it.

@wxiaoguang
Copy link
Contributor

I think #31205 was the last such issue.

I don't think it is related to version. The reporter just happened to be running pgsql 16

@GiteaBot GiteaBot added lgtm/need 1 This PR needs approval from one additional maintainer to be merged. and removed lgtm/need 2 This PR needs two approvals by maintainers to be considered for merging. labels Jul 4, 2025
@delvh
Copy link
Member

delvh commented Jul 4, 2025

I'm fine with whatever decision we make on this.

Copy link
Contributor

@wxiaoguang wxiaoguang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't think we need to do this. The CI is already pretty slow

@GiteaBot GiteaBot added lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged and removed lgtm/need 1 This PR needs approval from one additional maintainer to be merged. labels Jul 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm/blocked A maintainer has reservations with the PR and thus it cannot be merged modifies/internal
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants