[vscode-graphql-syntax] Add support for GraphQL embedded in Hack files #3872
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 261039b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Summary: This adds support for GraphQL strings within Hack files, bootstrapped from the existing PHP version. I followed the steps outlined in the README. Test Plan: - `yarn test -u` from package root - `yarn vsce:package` and install resulting VSIX - Load `test.hack` in VS Code - Observe nice syntax highlighting for GraphQL
Summary: This adds support for GraphQL strings within Hack files, bootstrapped from the existing PHP version. I followed the steps outlined in the README. Test Plan: - `yarn test -u` from package root - `yarn vsce:package` and install resulting VSIX - Load `test.hack` in VS Code - Observe nice syntax highlighting for GraphQL
|
@acao apologies for my GitHub noobiness, but does your force push mean this will be released? If not, is there anything I need to do to get this over the line? Thanks in advance :) |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3872 +/- ##
==========================================
+ Coverage 63.96% 63.99% +0.03%
==========================================
Files 35 35
Lines 3086 3086
Branches 934 934
==========================================
+ Hits 1974 1975 +1
+ Misses 1107 1106 -1
Partials 5 5 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
This adds support for GraphQL strings within Hack files, bootstrapped from the existing PHP version. I followed the steps outlined in the README.
Test Plan:
yarn test -ufrom package rootyarn vsce:packageand install resulting VSIXtest.hackin VS Code