-
Notifications
You must be signed in to change notification settings - Fork 112
Drop keylime example #3523
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop keylime example #3523
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR replaces the deprecated luet- and cloud-config examples with a Dockerfile for building the Keylime agent and rewrites the README to use Rocky Linux and more detailed Kairos-specific instructions.
- Removed outdated
luet.yaml
andkeylime.yaml
example files - Updated
README.md
with Rocky Linux install steps and expanded cloud-config - Added a multi-stage
Dockerfile
to build and package the Keylime agent
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 3 comments.
File | Description |
---|---|
examples/keylime/luet.yaml | Deleted deprecated Luet repository example |
examples/keylime/keylime.yaml | Deleted outdated cloud-config-only example |
examples/keylime/README.md | Revised install instructions, updated examples, clarified details |
examples/keylime/Dockerfile | New multi-stage build for the Keylime Rust agent |
Comments suppressed due to low confidence (2)
examples/keylime/README.md:11
- [nitpick] The official distribution name is “Rocky Linux” (two words). Please update ‘Rockylinux’ to ‘Rocky Linux’ for consistency.
> We use Rockylinux as it has the keylime packages available in the repositories. You can use any other distribution but you will need to manually install keylime packages on it (full Keylime package AND keylime-agent)
examples/keylime/README.md:127
- The systemd service is typically named
keylime-agent
, notkeylime_agent
. Please verify and correct the service name to ensure it actually starts.
- keylime_agent
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Really nice - to me it looks clear. I didn't tested it, but the flow and the example looks OK. Just a small nit at the start of the example where I'd give some hints on the docs.
@Itxaka I see we also have https://kairos.io/docs/examples/keylime/ - should we also update that part of the docs or is it updated automatically? |
That was just a pure copy of the previous readme here, so it needs either updating or maybe to simplify it with a remote include so it's always updated? |
maybe we can just move the examples directly in the docs and we avoid having it in both parts? we could just link from here to the example section in the docs to avoid 404s |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
dsf
The idea on having the examples here was so on change (bump stuff for example) we could auto test this directly, but in this case as its a derivative, it makes no sense and we can instead have it on the docs, sounds good to me then. |
Signed-off-by: Itxaka <itxaka@kairos.io>
Moved it do docs instead