Click Analytics - Fix capturning of HTML events #2587
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rather than by index.
There was a problem hiding this comment.
Pull Request Overview
This PR fixes an issue where HTML event sources were not recognized after changing the capture-element map from an object to an array by using arrIncludes for lookups.
- Imported
arrIncludesand replaced direct object-index checks witharrIncludesfor element tag matching. - Updated two conditionals in
AutoCaptureHandler.tsto use array-based inclusion logic.
Comments suppressed due to low confidence (1)
extensions/applicationinsights-clickanalytics-js/src/handlers/AutoCaptureHandler.ts:99
- Consider adding unit tests for the new array-based inclusion logic, including a scenario where a
<label>with aforattribute maps to its control, to prevent future regressions.
if (!arrIncludes(_clickCaptureElements, tagNameUpperCased)) {
extensions/applicationinsights-clickanalytics-js/src/handlers/AutoCaptureHandler.ts
Show resolved
Hide resolved
Karlie-777
approved these changes
Jun 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes made in #2504 (b5a24d5) appear to have introduced an issue when evaluating if events have come from known HTML objects. This appears to be due to a new array which had previously been an object still being indexed by its values. As a result these events are not being processed.
This change is to fix that by looking for the value in the array.