Fix URI Decode Logging Errors #1448
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1404
This pull request enhances the handling of
AUTH_USERcookies in theHttpRequestParserclass and adds comprehensive test cases to validate the changes. The updates improve robustness in cookie decoding, handle edge cases gracefully, and ensure better logging for malformed cookies.Enhancements to
HttpRequestParserfunctionality:_getIdmethod inHttpRequestParserto decode cookies more robustly, returningnullfor malformed cookies or missing values, and logging warnings for decoding errors. (AutoCollection/HttpRequestParser.ts, AutoCollection/HttpRequestParser.tsL252-R264)Addition of test cases:
HttpRequestParser.tests.tsto verify the behavior ofAUTH_USERcookie handling. This includes tests for valid cookies, malformed cookies, cookies with special characters, and scenarios with missing or empty cookies. (Tests/AutoCollection/HttpRequestParser.tests.ts, Tests/AutoCollection/HttpRequestParser.tests.tsR274-R414)Logging improvements:
Logging.warnin theHttpRequestParserclass to log decoding errors for malformed cookies, ensuring better traceability. (Tests/AutoCollection/HttpRequestParser.tests.ts, Tests/AutoCollection/HttpRequestParser.tests.tsR8-R9)