Deleted old files unnecessary collab SK and updated collaborative_multi_agent_RR.py #251
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR removes outdated collaborative multi-agent files and updates the remaining collaborative_multi_agent_RR.py file with enhanced debugging, logging, and serialization support. Key changes include:
- Removal of the SDK v2 and groupchat SDK v2 files.
- Addition of debugging logs and a new to_serializable method in collaborative_multi_agent_RR.py.
- Updates to the orchestration and agent response logic in chat_async.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| agentic_ai/agents/semantic_kernel/multi_agent/collaborative_multi_agent_sdkv2.py | File removed as it is no longer necessary. |
| agentic_ai/agents/semantic_kernel/multi_agent/collaborative_multi_agent_RR.py | Updated to add debugging, a serialization method, and improved logging. |
| agentic_ai/agents/semantic_kernel/multi_agent/collab_multi_agent_RR_groupchat_sdkv2.py | File removed as it is no longer necessary. |
Comments suppressed due to low confidence (1)
agentic_ai/agents/semantic_kernel/multi_agent/collaborative_multi_agent_RR.py:276
- [nitpick] Evaluate whether returning a JSON serialized string might better preserve the structure of the response for further processing, instead of using a general string conversion.
return str(answer)
| @@ -182,6 +205,7 @@ def make_agent(name, description, instructions, included_tools=[]): | |||
| "- Do not emit planning commentary or bullet lists to the user.\n" | |||
| "- Only ‘FINAL ANSWER’ messages or specialist delegations are allowed.\n" | |||
| "- After all agents discuss, make sure you respond only relevant information asked as per user request.\n" | |||
| "- It's possible in taking multiple turns you got different answers, but the most appropraite response was in one of the earlier rounds, so look at keywords in questions and map the response to closest keyword matching\n" | |||
There was a problem hiding this comment.
Typographical error: 'appropraite' should be corrected to 'appropriate'. Consider revising the sentence for clarity.
Suggested change
| "- It's possible in taking multiple turns you got different answers, but the most appropraite response was in one of the earlier rounds, so look at keywords in questions and map the response to closest keyword matching\n" | |
| "- It's possible in taking multiple turns you got different answers, but the most appropriate response was in one of the earlier rounds. Look at keywords in the questions and map the response to the closest keyword match.\n" |
Copilot uses AI. Check for mistakes.
Comment on lines
+259
to
+262
| # Debug log: show the type and repr of the value and value.content | ||
| logger.info(f"[DEBUG] orchestration_result.get() value: {repr(value)} (type: {type(value)})") | ||
| if hasattr(value, "content"): | ||
| answer = str(value.content) | ||
| logger.info(f"[DEBUG] value.content: {repr(value.content)} (type: {type(value.content)})") |
There was a problem hiding this comment.
Ensure that detailed debug logging does not expose sensitive data in production environments. Consider removing or reducing such logs when deploying.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.