Adds the Xbox Game Package Manager project to the 'main' branch for Package Uploader #80
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Updated `PackageUploadView.xaml` to include a new namespace for converters and added a `StringNotEmptyConverter` resource. Introduced a `VerticalStackLayout` for displaying success and error messages. Modified `BaseViewModel.cs` to include `System.Runtime.CompilerServices` for property change notifications. Updated `PackageCreationViewModel.cs` to enhance command format with logging options and improved output string handling for debugging. Enhanced `PackageUploadViewModel.cs` with new properties for success and error messages, and updated the configuration file path to include timestamps. Refined command formats for product retrieval and package uploads to include logging. Modified `StartUploadPackageProcess` to clear previous messages and log output based on process exit codes. Added `StringNotEmptyConverter` to improve data binding capabilities in the UI.
1. Drag drop support for game data folder or package file if only doing upload. 2. Data extraction from the package file (supporting upload only case). Reduced reliance on MakePkg output harvesting by relying on that extraction in both scenarios.
…once I figure out Delta upload (which isn't working for me at the moment), but it's a good start.
…e the preferences thanks to inbuilt MAUI tools
…t being used when new data coming in.
…some extra UI showing login details (pulls the 'name' claim from the JWT if possible).
… with most of the necessary functionality.
…ageUploader into PackageUploaderUI
…tuff looks close. Now it's just final details. TODO: Final details to get right fonts, fix alignments, and change colors for different button states. Also tie in EKB button.
…ageUploader into PackageUploaderUI
…ory is a lot simpler (less dependencies)
…ageUploader into PackageUploaderUI
…ageUploader into PackageUploaderUI
There was a problem hiding this comment.
Pull Request Overview
This PR integrates the new Xbox Game Package Manager UI tool into the Package Uploader solution, enhances authentication flows with multi-tenant and cacheable browser credentials, and updates CLI options, DI registrations, documentation, and package versions.
- Introduce cacheable browser credential provider, Azure tenant service, and reset mechanisms for multi-tenant token management
- Add
-t/--TenantIdCLI option, update command-line configuration mappings, and extend DI for new auth flows - Bump ILCompiler to 8.0.17, enable security defaults, and document the Xbox Game Package Manager in README/SUPPORT
Reviewed Changes
Copilot reviewed 207 out of 207 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/Models/AzureTenants.cs | Add AzureTenant and AzureTenantList models |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/InteractiveBrowserCredentialAccessTokenProvider.cs | Support tenant ID in browser authentication |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/IAuthenticationResetService.cs | Define IAuthenticationResetService interface |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/CredentialAccessTokenProvider.cs | Expose protected Logger field |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/Config/AccessTokenProviderConfig.cs | Add AzureManagementBaseUrl to config |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/ClientSecretCredentialAccessTokenProvider.cs | Migrate to ClientSecretAuthInfo and update error messages |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/ClientCertificateCredentialAccessTokenProvider.cs | Migrate to ClientCertificateAuthInfo and load certificates |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/CachableInteractiveBrowserCredentialAccessToken.cs | Implement token caching and Azure tenant listing |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/AzureTenantService.cs | Implement IAzureTenantService for tenant enumeration |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/AuthenticationResetService.cs | Reset global token handlers and MSAL cache |
| src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/AccessTokenProviderExtensions.cs | Register new auth providers, tenant services, and options |
| src/PackageUploader.ClientApi/Client/Ingestion/IngestionAuthenticationDelegatingHandler.cs | Make handler public and register for reset |
| src/PackageUploader.Application/packages.lock.json | Bump Microsoft.DotNet.ILCompiler to 8.0.17 |
| src/PackageUploader.Application/Program.cs | Add TenantIdOption and update command-line mapping |
| src/PackageUploader.Application/PackageUploader.Application.csproj | Enable HighEntropyVA security setting |
| src/Directory.Build.props | Apply <HighEntropyVA> and strict features globally |
| SUPPORT.md | Revise support instructions |
| README.md | Document Xbox Game Package Manager section |
| .github/workflows/dotnet.yml | Setup .NET build and test workflow |
| .github/workflows/codeql.yml | Customize CodeQL build steps |
Comments suppressed due to low confidence (1)
SUPPORT.md:9
- [nitpick] The use of "etc." is vague. List all supported contributors explicitly or point to a CONTRIBUTORS file to avoid uncertainty.
For help and questions about using this project, please open an issue indicating you need help and tag the active Contributors (WilliamsJason, Zenidog8, toekneeparkms, etc.).
src/PackageUploader.ClientApi/Client/Ingestion/TokenProvider/AccessTokenProviderExtensions.cs
Outdated
Show resolved
Hide resolved
...r.ClientApi/Client/Ingestion/TokenProvider/ClientCertificateCredentialAccessTokenProvider.cs
Show resolved
Hide resolved
…P-UI-updates-06-16-2025-57953910 Updates to some ja-JP UI text per audit
…ageUploader into PackageUploaderUI
…specifically validating the recent regression around ClientSecret being required for AppSecret auth type
… to override logging to verbose in UI tool
Zenidog8
approved these changes
Jun 20, 2025
…Me-updates-06-20-2025-57953936 Updates per edit pass
Zenidog8
approved these changes
Jun 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the Xbox Game Package Manager (UI tool over the Package Uploader)
The Xbox Game Package Manager is a Windows desktop application that provides a user-friendly graphical interface for the Package Uploader functionality. This tool simplifies both package creation and upload operations with the following key features:
Package Creation
Package Upload
Benefits