-
Notifications
You must be signed in to change notification settings - Fork 7
Add image creator #258
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add image creator #258
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cwize1
requested changes
Jun 3, 2025
89eb121
to
19220fb
Compare
cwize1
requested changes
Jun 6, 2025
cwize1
requested changes
Jun 9, 2025
24e6a09
to
504361e
Compare
cwize1
requested changes
Jun 18, 2025
toolkit/tools/internal/testutils/testrpms/download-test-rpms.sh
Outdated
Show resolved
Hide resolved
toolkit/tools/internal/testutils/testrpms/download-test-rpms.sh
Outdated
Show resolved
Hide resolved
toolkit/tools/internal/testutils/testrpms/downloader/Dockerfile
Outdated
Show resolved
Hide resolved
toolkit/tools/internal/testutils/testrpms/downloader/Dockerfile
Outdated
Show resolved
Hide resolved
7941a85
to
f92cde9
Compare
cwize1
requested changes
Jun 18, 2025
toolkit/tools/internal/testutils/testrpms/download-test-rpms.sh
Outdated
Show resolved
Hide resolved
21d3518
to
1127c25
Compare
resolve comments revert changes in imager code resolve feedback fix issues with bindmounts add tests fix rebase resolve comments resolve comments skip imagecreation tests by default resolve feedback
58c9305
to
5222518
Compare
cwize1
previously approved these changes
Jun 20, 2025
cwize1
approved these changes
Jun 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new tool image creator that creates seed images
Added a new module for image creator
Added a new share testutils module
follow-up PRs:
Checklist