Skip to content

Table design changes can be published without approving #26139

Open
@winzig

Description

@winzig

Type: Bug

When you use the table designer to make changes to a table, and then you hit the publish button, you're shown a summary of the changes, and then at the bottom, you have an active Cancel button, and a checkbox to approve the changes. The buttons to publish the changes are only activated if you check the box.

HOWEVER...

If when that dialog box appears you just hit the ENTER/RETURN key, they will get published even without checking the box. So I think perhaps that dialog needs the Cancel button to be set as default or something?

ALSO: the reason I even ran into this bug was because I was trying to make some changes that resulted in the approval dialog box extending beyond my screen, so the buttons to choose what to do were off-screen. I decided to hit ENTER, and that published my changes. So I think a secondary bug is that the dialog needs to be re-worked so that the changes are in a scrollable div, and the button area is always visible?

Azure Data Studio version: azuredatastudio 1.50.0 (49c73a8, 2024-11-17T22:25:36.863Z)
OS version: Darwin arm64 24.2.0
Restricted Mode: No
Preview Features: Enabled
Modes:

System Info
Item Value
CPUs Apple M1 Max (10 x 2400)
GPU Status 2d_canvas: enabled
canvas_oop_rasterization: enabled_on
direct_rendering_display_compositor: disabled_off_ok
gpu_compositing: enabled
multiple_raster_threads: enabled_on
opengl: enabled_on
rasterization: enabled
raw_draw: disabled_off_ok
skia_graphite: disabled_off
video_decode: enabled
video_encode: enabled
webgl: enabled
webgl2: enabled
webgpu: enabled
webnn: disabled_off
Load (avg) 3, 3, 4
Memory (System) 64.00GB (1.16GB free)
Process Argv
Screen Reader no
VM 0%
Extensions (13)
Extension Author (truncated) Version
copilot Git 1.242.0
admin-pack Mic 0.0.2
agent Mic 0.49.0
dacpac Mic 1.14.0
import Mic 1.6.1
profiler Mic 0.14.0
query-history Mic 0.5.3
schema-compare Mic 1.21.0
server-report Mic 0.2.4
dotnet-interactive-vscode ms- 1.0.3504060
jupyter ms- 2022.4.1021342353
partial-diff ryu 1.4.3
code-settings-sync Sha 3.4.3

(1 theme extensions excluded)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions